-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cache at Step
level
#766
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #766 will degrade performances by 25.09%Comparing Summary
Benchmarks breakdown
|
…to cache-per-step
Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-766/ |
…to cache-per-step
da9985b
to
0b35f96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements cache at step level.
Previously, we computed a signature for a pipeline, and when this signature changed, we recomputed everything.
Now the idea is to compute the signature per step, and once the signature has changed, only recompute the steps whose signature (or preceding) has changed. So for a pipeline
A -> B -> C
, ifB
step changes, we will recompute onlyB
andC
, but we will start with the data we had fromA
.New cases we control with this change:
Ctrl+c
), we can restart from where we left.a >> b >> c >> d
and we change a step (sayc
), we will only recomputec
andd
.step
level. We have an argumentuse_cache
at the_Step
level, when set to False, the cache won't be used from that step onwards, even if the pipeline remains the same.Note: This has an impact in how we read the previous serialized parquet files, if any step's use_cache is set to False, for a pipeline that hasn't changed, we won't read the previous serialized content.
Closes #651