Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issues related to Magpie task #783

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Fix some issues related to Magpie task #783

merged 5 commits into from
Jul 16, 2024

Conversation

gabrielmbmb
Copy link
Contributor

@gabrielmbmb gabrielmbmb commented Jul 15, 2024 •
edited
Loading

Description

Fixed for Magpie and MagpieGenerator:

  • Missing model_name output column
  • Inputs columns were not being included.

@github-actions GitHub Actions
Copy link

Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-783/

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 15, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #783 will not alter performance

Comparing magpie-fixes (be7ce34) with develop (4fc569d)

Summary

✅ 1 untouched benchmarks

@gabrielmbmb gabrielmbmb self-assigned this Jul 16, 2024
@gabrielmbmb gabrielmbmb added this to the 1.3.0 milestone Jul 16, 2024
@gabrielmbmb gabrielmbmb marked this pull request as ready for review July 16, 2024 08:00
@gabrielmbmb gabrielmbmb merged commit b22a494 into develop Jul 16, 2024
7 checks passed
@gabrielmbmb gabrielmbmb deleted the magpie-fixes branch July 16, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gabrielmbmb gabrielmbmb

Labels
fix
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@gabrielmbmb