You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some function uses context.TODO or context.Background. So it's better to replace these to propagate context cancellation.
Motivation
Currenty, some function uses context.TODO or context.Background. As a result, some connection might be leaked, since the context isn't propagated.
In additional, context.TODO is ambiguous whether these codes are planed to replace right context or not.
Thus, I think it should replace context.Background instead of context.TODO.
Proposal
This migration might be done by 2 step.
Add static analysis to forbid context.TODO and context.Background for finding thesd.
propagate context from cmd/** to some functions
Remain context.Background if it's impossible to replace
What do you think ?
The text was updated successfully, but these errors were encountered:
Summary
Some function uses context.TODO or context.Background. So it's better to replace these to propagate context cancellation.
Motivation
Currenty, some function uses context.TODO or context.Background. As a result, some connection might be leaked, since the context isn't propagated.
In additional, context.TODO is ambiguous whether these codes are planed to replace right context or not.
Thus, I think it should replace context.Background instead of context.TODO.
Proposal
This migration might be done by 2 step.
What do you think ?
The text was updated successfully, but these errors were encountered: