Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Allow https ingress/external links without a secretName #21980

Open
bojanraic opened this issue Feb 24, 2025 · 0 comments
Open

UI: Allow https ingress/external links without a secretName #21980

bojanraic opened this issue Feb 24, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@bojanraic
Copy link

Summary

UI application tiles show http links for application ingresses where TLS host is set but there is no secretName explicitly associated. This can be viewed as a bit misleading in setups involving a wildcard TLS cert.
It would be nice to be able to control this behavior via config option/parameter and allow showing https links for tls-enabled ingresses without a secretName.

Motivation

When using a wildcard TLS certificate, we can let the ingress controller serve the wildcard certificate by default for any ingresses without an explicit secretName. Yet currently, due to the explicit check for presence of secretName, Argo UI will always show http links.

Proposal

Introduce a new config option/parameter, something like allowImpliedHttpsIngressLinks with the default being false. If set to true, consider the scenario of "Ingress TLS host present, but without a secretName", an implied, yet valid TLS setup.

Thus, when allowImpliedHttpsIngressLinks is true, an explicit secretName should not be required for building an https link for UI application tiles.

If/when added, this option/parameter should also make its way to the Helm chart.

@bojanraic bojanraic added the enhancement New feature or request label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant