You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
UI application tiles show http links for application ingresses where TLS host is set but there is no secretName explicitly associated. This can be viewed as a bit misleading in setups involving a wildcard TLS cert.
It would be nice to be able to control this behavior via config option/parameter and allow showing https links for tls-enabled ingresses without a secretName.
Motivation
When using a wildcard TLS certificate, we can let the ingress controller serve the wildcard certificate by default for any ingresses without an explicit secretName. Yet currently, due to the explicit check for presence of secretName, Argo UI will always show http links.
Proposal
Introduce a new config option/parameter, something like allowImpliedHttpsIngressLinks with the default being false. If set to true, consider the scenario of "Ingress TLS host present, but without a secretName", an implied, yet valid TLS setup.
Thus, when allowImpliedHttpsIngressLinks is true, an explicit secretName should not be required for building an https link for UI application tiles.
If/when added, this option/parameter should also make its way to the Helm chart.
The text was updated successfully, but these errors were encountered:
Summary
UI application tiles show http links for application ingresses where TLS host is set but there is no
secretName
explicitly associated. This can be viewed as a bit misleading in setups involving a wildcard TLS cert.It would be nice to be able to control this behavior via config option/parameter and allow showing https links for tls-enabled ingresses without a
secretName
.Motivation
When using a wildcard TLS certificate, we can let the ingress controller serve the wildcard certificate by default for any ingresses without an explicit
secretName
. Yet currently, due to the explicit check for presence ofsecretName
, Argo UI will always show http links.Proposal
Introduce a new config option/parameter, something like
allowImpliedHttpsIngressLinks
with the default beingfalse
. If set totrue
, consider the scenario of "Ingress TLS host present, but without a secretName", an implied, yet valid TLS setup.Thus, when
allowImpliedHttpsIngressLinks
istrue
, an explicitsecretName
should not be required for building an https link for UI application tiles.If/when added, this option/parameter should also make its way to the Helm chart.
The text was updated successfully, but these errors were encountered: