Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Improve stability of cargo-udeps in GitHub actions #17

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

huitseeker
Copy link
Contributor

  • Updated the execution process for cargo-udeps in GitHub actions.
  • Enhanced stability by using RUSTC_BOOTSTRAP variable in unused-deps.yml.

THis should help solve lurk-lang/arecibo#247

- Updated the execution process for `cargo-udeps` in GitHub actions.
- Enhanced stability by using `RUSTC_BOOTSTRAP` variable in `unused-deps.yml`.

THis should help solve lurk-lang/arecibo#247
# opt to use the stable toolchain specified via the 'rust-toolchain' file
# and instead enable nightly features via 'RUSTC_BOOTSTRAP'
- name: run cargo-udeps
run: RUSTC_BOOTSTRAP=1 cargo udeps --lib --features "${{ inputs.repository }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be ${{ inputs.features }}?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed!

@huitseeker huitseeker added this pull request to the merge queue Jan 10, 2024
Merged via the queue into argumentcomputer:main with commit e8dc4db Jan 10, 2024
@huitseeker huitseeker deleted the udeps-bootstrap branch January 10, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants