Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bench-pr-comment.yml env #66

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Fix bench-pr-comment.yml env #66

merged 1 commit into from
Apr 30, 2024

Conversation

samuelburnham
Copy link
Member

@samuelburnham samuelburnham commented Apr 30, 2024

Env vars are currently not being set properly as they are interpreted as one string literal rather than a list of strings. This leads to downstream issues such as lurk-lang/arecibo#381 (comment).

The values expand to multiple strings properly by removing quotes.

Successful runs: argumentcomputer/ci-lab#88

@samuelburnham samuelburnham added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit 5929054 Apr 30, 2024
@samuelburnham samuelburnham deleted the bench-pr-env branch April 30, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants