Rework state and postal code matching #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmelninkas
force-pushed
the
rework-state-postal-code
branch
from
39c846f to
72f8002
Compare
lmelninkas
force-pushed
the
rework-state-postal-code
branch
from
72f8002 to
c1db33d
Compare
DeviousStoat
approved these changes
Apr 25, 2024
lmelninkas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Difficult edge case - potential state name is part of city name:
This PR attempts implement the restriction that we should match the state name and postal code each at most one, but requite at least one of the two.