Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle various edge cases around US postal code #51

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Handle various edge cases around US postal code #51

merged 2 commits into from
Apr 26, 2024

Conversation

lmelninkas
Copy link

@lmelninkas lmelninkas commented Apr 25, 2024 •
edited
Loading

  • Updated the negative lookahead matcher for postal code
  • Handle country in front of the postal code

@lmelninkas lmelninkas changed the title Detect postal code after a line break Handle various edge cases around US postal code Apr 25, 2024
@lmelninkas lmelninkas force-pushed the rework-state-postal-code branch from bf95eed to b005cf1 Compare April 25, 2024 18:59
@lmelninkas lmelninkas marked this pull request as ready for review April 25, 2024 19:29
@lmelninkas lmelninkas requested a review from DeviousStoat April 25, 2024 19:29
@lmelninkas lmelninkas merged commit a845a50 into master Apr 26, 2024
7 checks passed
@lmelninkas lmelninkas deleted the rework-state-postal-code branch April 26, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeviousStoat DeviousStoat DeviousStoat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmelninkas @DeviousStoat