Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(anta.tests): Nicer result failure messages PTP, software test module #1038

Merged
merged 4 commits into from
Feb 13, 2025
Merged

refactor(anta.tests): Nicer result failure messages PTP, software test module #1038

merged 4 commits into from
Feb 13, 2025
+128 −48

Conversation

geetanjalimanegslab
Copy link
Collaborator

@geetanjalimanegslab geetanjalimanegslab commented Feb 11, 2025 •
edited
Loading

Nicer result failure messages for following test module.
1 . PTP
2. Software

Note: Test with unit test only, as this testcases are skipped on ATD lab
Fixes #587

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@geetanjalimanegslab geetanjalimanegslab self-assigned this Feb 11, 2025
@geetanjalimanegslab geetanjalimanegslab mentioned this pull request Feb 11, 2025
Closed
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 11, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1038 will not alter performance

Comparing geetanjalimanegslab:fix_ptp_software_module_failure_msg (fa62573) with main (593959c)

Summary

✅ 22 untouched benchmarks

carl-baillargeon
carl-baillargeon requested changes Feb 13, 2025
View reviewed changes
tests/units/anta_tests/test_software.py Outdated Show resolved Hide resolved
tests/units/anta_tests/test_software.py Outdated Show resolved Hide resolved
tests/units/anta_tests/test_software.py Outdated Show resolved Hide resolved
tests/units/anta_tests/test_ptp.py Outdated Show resolved Hide resolved
tests/units/anta_tests/test_ptp.py Outdated Show resolved Hide resolved
tests/units/anta_tests/test_ptp.py Outdated Show resolved Hide resolved
examples/tests.yaml Outdated Show resolved Hide resolved
examples/tests.yaml Outdated Show resolved Hide resolved
@geetanjalimanegslab geetanjalimanegslab force-pushed the fix_ptp_software_module_failure_msg branch from 97cc06f to fa2d6d5 Compare February 13, 2025 11:24
@geetanjalimanegslab geetanjalimanegslab marked this pull request as ready for review February 13, 2025 16:30
carl-baillargeon
carl-baillargeon approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@carl-baillargeon carl-baillargeon merged commit f3ccdfa into aristanetworks:main Feb 13, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@vitthalmagadum vitthalmagadum Awaiting requested review from vitthalmagadum

Assignees

@geetanjalimanegslab geetanjalimanegslab

Labels
rn: refactor(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have nicer result failure messages
2 participants
@geetanjalimanegslab @carl-baillargeon