Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add support for RSS interface profile for select p… #5009

Draft
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

ashenoy-arista
Copy link
Contributor

@ashenoy-arista ashenoy-arista commented Feb 10, 2025

Change Summary

Build schema for eos_designs role to help generate structured config for RSS interface profile.
RSS interface profile is only applicable to certain SFE (Software Forwarding Engine) hardware platforms.
We would like to have toggle/knob under platform_settings -> feature_support schema that end-user can enable for supported hardware platforms to allow generation of relevant structured config.

Related Issue(s)

Fixes #4983

Component(s) name

arista.avd.eos_designs

Proposed changes

Propose adding rx_queue dictionary type under L3 interface and member eth interfaces of L3 Port-Channel interface.
The keys within this dictionary would be count, worker and mode.
Add a knob under platform_settings -> feature_support schema. When enabled, underlying logic would generate structured config for RSS profile for devices capable of supporting this feature. Such profile would include sections for each interface for which rx_queue dictionary type has been specified/populated in yml.
There will be only one such RSS profile generated and same profile would be set as the chosen profile to apply for the system.

How to test

TBD

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5009
# Activate the virtual environment
source test-avd-pr-5009/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ashenoy-arista/avd.git@eosDesignsRssProfileSupport#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ashenoy-arista/avd.git#/ansible_collections/arista/avd/,eosDesignsRssProfileSupport --force
# Optional: Install AVD examples
cd test-avd-pr-5009
ansible-playbook arista.avd.install_examples

@ashenoy-arista ashenoy-arista force-pushed the eosDesignsRssProfileSupport branch from ac5db61 to 44d2491 Compare February 11, 2025 00:59
@ashenoy-arista ashenoy-arista force-pushed the eosDesignsRssProfileSupport branch from ab65f89 to 02fd8de Compare February 11, 2025 23:25
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 13, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ashenoy-arista ashenoy-arista force-pushed the eosDesignsRssProfileSupport branch 2 times, most recently from d097795 to 0c7fb4c Compare February 15, 2025 02:39
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 15, 2025
@ashenoy-arista ashenoy-arista force-pushed the eosDesignsRssProfileSupport branch from 0c7fb4c to fa284e3 Compare February 15, 2025 02:42
@ashenoy-arista
Copy link
Contributor Author

ashenoy-arista commented Feb 15, 2025

Initial logic implementation in eos_designs to validate input yml and generate structured config for RSS profiles.
Molecule unit test has been added.
Negative unit test cases to be added next.

@ashenoy-arista ashenoy-arista force-pushed the eosDesignsRssProfileSupport branch from fa284e3 to b3d54d9 Compare February 18, 2025 23:07
@ashenoy-arista ashenoy-arista force-pushed the eosDesignsRssProfileSupport branch from b3d54d9 to 4edf20b Compare February 19, 2025 07:53
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Feb 19, 2025
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support configuration of Receive Side Scaling (RSS) interface profiles for select SFE based platforms
3 participants