-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_designs): structured_config for loopback #5018
Merged
ClausHolbechArista
merged 12 commits into
aristanetworks:devel
from
Vibhu-gslab:refactor_loopback
Feb 19, 2025
Merged
Refactor(eos_designs): structured_config for loopback #5018
ClausHolbechArista
merged 12 commits into
aristanetworks:devel
from
Vibhu-gslab:refactor_loopback
Feb 19, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5018
# Activate the virtual environment
source test-avd-pr-5018/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@refactor_loopback#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,refactor_loopback --force
# Optional: Install AVD examples
cd test-avd-pr-5018
ansible-playbook arista.avd.install_examples |
01c5258
to
8fe6360
Compare
python-avd/pyavd/_eos_designs/structured_config/underlay/loopback_interfaces.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/loopback_interfaces.py
Outdated
Show resolved
Hide resolved
575a4e0
to
f4b3281
Compare
laxmikantchintakindi
approved these changes
Feb 13, 2025
python-avd/pyavd/_eos_designs/structured_config/underlay/loopback_interfaces.py
Outdated
Show resolved
Hide resolved
laxmikantchintakindi
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
02ecd2c
to
70b9c42
Compare
MaheshGSLAB
reviewed
Feb 14, 2025
python-avd/pyavd/_eos_designs/structured_config/network_services/loopback_interfaces.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/loopback_interfaces.py
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/loopback_interfaces.py
Outdated
Show resolved
Hide resolved
70b9c42
to
b46b4ce
Compare
python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/virtual_source_nat_vrfs.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/loopback_interfaces.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/loopback_interfaces.py
Outdated
Show resolved
Hide resolved
774b4c6
to
48a8031
Compare
…ack_interfaces.py Co-authored-by: laxmikantchintakindi <159624484+laxmikantchintakindi@users.noreply.github.com>
…es/loopback_interfaces.py Co-authored-by: laxmikantchintakindi <159624484+laxmikantchintakindi@users.noreply.github.com>
…ack_interfaces.py Co-authored-by: laxmikantchintakindi <159624484+laxmikantchintakindi@users.noreply.github.com>
…es/loopback_interfaces.py Co-authored-by: Mahesh Kumar <122076792+MaheshGSLAB@users.noreply.github.com>
…ack_interfaces.py Co-authored-by: Mahesh Kumar <122076792+MaheshGSLAB@users.noreply.github.com>
c85ed0c
to
db8bae7
Compare
|
ClausHolbechArista
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Refactor eos_designs structured_config for loopback
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designs
Proposed changes
How to test
Checklist
Repository Checklist