Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs): structured_config for loopback #5018

Merged
merged 12 commits into from
Feb 19, 2025

Conversation

Vibhu-gslab
Copy link
Contributor

Change Summary

Refactor eos_designs structured_config for loopback

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_designs

Proposed changes

How to test

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Vibhu-gslab Vibhu-gslab self-assigned this Feb 12, 2025
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5018
# Activate the virtual environment
source test-avd-pr-5018/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@refactor_loopback#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,refactor_loopback --force
# Optional: Install AVD examples
cd test-avd-pr-5018
ansible-playbook arista.avd.install_examples

@Vibhu-gslab Vibhu-gslab force-pushed the refactor_loopback branch 2 times, most recently from 01c5258 to 8fe6360 Compare February 12, 2025 11:28
@Vibhu-gslab Vibhu-gslab changed the title Refactor(eos_designs): structured_config for loopback (WIP) Refactor(eos_designs): structured_config for loopback Feb 12, 2025
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review February 13, 2025 08:53
@laxmikantchintakindi laxmikantchintakindi requested review from a team as code owners February 13, 2025 08:53
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc marked this pull request as draft February 17, 2025 16:01
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review February 18, 2025 07:30
@Vibhu-gslab Vibhu-gslab marked this pull request as draft February 18, 2025 09:11
@Vibhu-gslab Vibhu-gslab force-pushed the refactor_loopback branch 2 times, most recently from 774b4c6 to 48a8031 Compare February 18, 2025 13:20
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review February 18, 2025 13:21
Vibhu-gslab and others added 9 commits February 19, 2025 11:22
…ack_interfaces.py

Co-authored-by: laxmikantchintakindi <159624484+laxmikantchintakindi@users.noreply.github.com>
…es/loopback_interfaces.py

Co-authored-by: laxmikantchintakindi <159624484+laxmikantchintakindi@users.noreply.github.com>
…ack_interfaces.py

Co-authored-by: laxmikantchintakindi <159624484+laxmikantchintakindi@users.noreply.github.com>
…es/loopback_interfaces.py

Co-authored-by: Mahesh Kumar <122076792+MaheshGSLAB@users.noreply.github.com>
…ack_interfaces.py

Co-authored-by: Mahesh Kumar <122076792+MaheshGSLAB@users.noreply.github.com>
@ClausHolbechArista ClausHolbechArista merged commit 8b1f435 into aristanetworks:devel Feb 19, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants