Fix(eos_designs): Raise again on conflicting ethernet interfaces under point-to-point services

[gmuloc]

Change Summary

This was missed in #4976

Component(s) name

arista.avd.eos_designs

Proposed changes

Add back the check historically implemented in append_if_not_duplicate(ignore_same_dict=False) which does not exist in new classes

How to test

molecule should catch it - no more structured_config for negative unit tests

Checklist

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5058
# Activate the virtual environment
source test-avd-pr-5058/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@fix-network-service-ethernet-interfaces#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,fix-network-service-ethernet-interfaces --force
# Optional: Install AVD examples
cd test-avd-pr-5058
ansible-playbook arista.avd.install_examples

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud