Always convert full to jpeg and use it in manifest thumbnail
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/plugin.js
Outdated
| @@ -187,6 +187,7 @@ class TropiiifyPlugin { | |||
| await new Promise((resolve, reject) => { | |||
| sharpInstance | |||
| .resize(maxDimension, maxDimension, { fit: 'inside' }) | |||
| .jpeg() | |||
There was a problem hiding this comment.
Hi @atomotic, you will need to change the destination path in line 205 as well so the file gets saved with the correct extension
There was a problem hiding this comment.
yes, it's in this commit 3286664 sorry if they are different, I went ahead by trial and error
|
Thanks for this! |
|
solves #20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix the conversion of
fulltiles to jpeg.I am still testing on my tropy collections