Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always convert full to jpeg and use it in manifest thumbnail #21

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Always convert full to jpeg and use it in manifest thumbnail #21

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
136a51b
Always convert full to jpeg
atomotic Jul 11, 2024
3286664
fix full name
atomotic Jul 11, 2024
7ccf668
fix addThumbnail() to use image/jpeg
atomotic Jul 11, 2024
95382ae
Merge branch 'main' into main
martimpassos Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ class TropiiifyPlugin {
await new Promise((resolve, reject) => {
sharpInstance
.resize(maxDimension, maxDimension, { fit: 'inside' })
.jpeg()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @atomotic, you will need to change the destination path in line 205 as well so the file gets saved with the correct extension

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's in this commit 3286664 sorry if they are different, I went ahead by trial and error

.toBuffer((err, data, info) => {
if (err) {
console.error('Error:', err);
Expand Down