feat: Allow skipping of constraint generation during proving #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add witness_mapping field to ConstraintSystem struct Initialize the field in new() method
Modifies the benchmark example to demonstrate the constraint generation skipping functionality. Runs the example twice: first to generate constraints and create the witness mapping, and second to use the mapping to skip constraint generation, showing the performance improvement.
Adds wrapper methods to ConstraintSystemRef for accessing and modifying the witness mapping functionality in the underlying ConstraintSystem. Enables users to access the mapping through the reference type without direct access to the constraint system.
VolodymyrBg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a mechanism to skip constraint generation during proving by storing a mapping between unoptimized and optimized witnesses. When the prover runs with construct_matrices=false, it can use this mapping to directly evaluate linear combinations without reconstructing the full constraint matrices, significantly improving proving performance.
The implementation adds a new witness_mapping field to the ConstraintSystem structure, updates the enforce_constraint method to use this mapping when appropriate, and adds methods to get/set the mapping through both ConstraintSystem and ConstraintSystemRef. A benchmark example is also updated to demonstrate the performance improvement.
closes: #328
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer