fix: firefly-itx-3588j fails to boot, and audio output #6849

SeeleVolleri · 2024-07-01T00:06:03Z

Description

Change to mainline uboot, fixed not booting issue, added hdmi0 audio interface alias.

How Has This Been Tested?

./compile.sh build BOARD=firefly-itx-3588j BRANCH=vendor BUILD_DESKTOP=yes BUILD_MINIMAL=no DESKTOP_APPGROUPS_SELECTED='browsers internet' DESKTOP_ENVIRONMENT=gnome DESKTOP_ENVIRONMENT_CONFIG_NAME=config_base KERNEL_CONFIGURE=no RELEASE=bookworm
[x]

Checklist:

Please delete options that are not relevant.

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

...boot/legacy/u-boot-radxa-rk3588/board_firefly-itx-3588j/uboot-firefly-itx-3588j-config.patch

ColorfulRhino · 2024-07-01T00:31:20Z

Try this : #6851

SeeleVolleri · 2024-07-01T14:56:22Z

Thanks!

Try this : #6851

ColorfulRhino · 2024-07-01T16:15:15Z

Thanks!

Try this : #6851

You're welcome! Thanks for testing mainline.

I think with the patch in the u-boot patch fodler you will actually change something for the Rock 5A as well, which is not intended. I know it's in its own boot folder, but last time I checked, the boot folder is just cosmetic (to know which patches are from which boards so they can be moved if the board moves) and the patcher will take all patches from all subfolders for all boards.

Please try the current board config with BOOTCONFIG="rk3588_defconfig" and BOOTCONFIG="rock-5a-rk3588s_defconfig", but without the uboot-firefly-itx-3588j-config.patch

SeeleVolleri · 2024-07-02T01:01:18Z

Please try the current board config with BOOTCONFIG="rk3588_defconfig" and BOOTCONFIG="rock-5a-rk3588s_defconfig", but without the uboot-firefly-itx-3588j-config.patch

BOOTCONFIG="rk3588_defconfig" goes

DDR 9fffbe1e78 cym 24/02/04-10:09:20,fwver: v1.16
LPDDR4X, 2112MHz
channel[0] BW=16 Col=10 Bk=8 CS0 Row=17 CS=1 Die BW=16 Size=2048MB
channel[1] BW=16 Col=10 Bk=8 CS0 Row=17 CS=1 Die BW=16 Size=2048MB
channel[2] BW=16 Col=10 Bk=8 CS0 Row=17 CS=1 Die BW=16 Size=2048MB
channel[3] BW=16 Col=10 Bk=8 CS0 Row=17 CS=1 Die BW=16 Size=2048MB
Manufacturer ID:0xff
CH0 RX Vref:26.7%, TX Vref:20.8%,0.0%
CH1 RX Vref:28.9%, TX Vref:21.8%,0.0%
CH2 RX Vref:29.7%, TX Vref:20.8%,0.0%
CH3 RX Vref:28.9%, TX Vref:20.8%,0.0%
change to F1: 528MHz
change to F2: 1068MHz
change to F3: 1560MHz
change to F0: 2112MHz
out
U-Boot SPL board init
U-Boot SPL 2017.09-armbian (Jul 01 2024 - 14:12:28)
unrecognized JEDEC id bytes: 00, 00, 00
unknown raw ID 0 0 0
Trying to boot from MMC2
spl: partition error
Trying fit image at 0x4000 sector
## Verified-boot: 0
## Checking atf-1 0x00040000 ... sha256(a7d1d8d191...) + OK
## Checking uboot 0x00200000 ... sha256(7c720b0cf7...) + OK
## Checking fdt 0x0033fae8 ... sha256(912cda2231...) + OK
## Checking atf-2 0xff100000 ... sha256(4b2065349b...) + OK
## Checking atf-3 0x000f0000 ... sha256(aa71013e72...) + OK
Jumping to U-Boot(0x00200000) via ARM Trusted Firmware(0x00040000)
Total: 435.285/563.990 ms

INFO:    Preloader serial: 2
NOTICE:  BL31: v2.3():v2.3-682-g4ca8a8422:derrick.huang, fwver: v1.45
NOTICE:  BL31: Built : 10:11:21, Dec 27 2023
INFO:    spec: 0x1
INFO:    code: 0x88
INFO:    ext 32k is not valid
INFO:    ddr: stride-en 4CH
INFO:    GICv3 without legacy support detected.
INFO:    ARM GICv3 driver initialized in EL3
INFO:    valid_cpu_msk=0xff bcore0_rst = 0x0, bcore1_rst = 0x0
INFO:    l3 cache partition cfg-0
INFO:    system boots from cpu-hwid-0
INFO:    disable memory repair
INFO:    idle_st=0x21fff, pd_st=0x11fff9, repair_st=0xfff70001
INFO:    dfs DDR fsp_params[0].freq_mhz= 2112MHz
INFO:    dfs DDR fsp_params[1].freq_mhz= 528MHz
INFO:    dfs DDR fsp_params[2].freq_mhz= 1068MHz
INFO:    dfs DDR fsp_params[3].freq_mhz= 1560MHz
INFO:    BL31: Initialising Exception Handling Framework
INFO:    BL31: Initializing runtime services
WARNING: No OPTEE provided by BL2 boot loader, Booting device without OPTEE initialization. SMC`s destined for OPTEE will return SMC_UNK
ERROR:   Error initializing runtime service opteed_fast
INFO:    BL31: Preparing for EL3 exit to normal world
INFO:    Entry point address = 0x200000
INFO:    SPSR = 0x3c9


U-Boot 2017.09-armbian (Jul 01 2024 - 23:28:47 +0000)

Model: Rockchip RK3588 Evaluation Board
MPIDR: 0x81000000
PreSerial: 2, raw, 0xfeb50000
DRAM:  8 GiB
Sysmem: init
Relocation Offset: eda1e000
Relocation fdt: eb9fa7c0 - eb9fecd8
CR: M/C/I
Using default environment

optee check api revision fail: -1.0
optee api revision is too low
### ERROR ### Please RESET the board ###

SeeleVolleri · 2024-07-02T01:05:15Z

I think with the patch in the u-boot patch fodler you will actually change something for the Rock 5A as well, which is not intended. I know it's in its own boot folder, but last time I checked, the boot folder is just cosmetic (to know which patches are from which boards so they can be moved if the board moves) and the patcher will take all patches from all subfolders for all boards.

it didn't happened, so I assume keeping the patch won't affect rock-5a?
https://paste.armbian.com/mexelojini

SeeleVolleri · 2024-07-02T04:30:43Z

Please try the current board config with BOOTCONFIG="rk3588_defconfig" and BOOTCONFIG="rock-5a-rk3588s_defconfig", but without the uboot-firefly-itx-3588j-config.patch

Here comes rock-5a-rk3588s_defconfig without patch:
just model are different, boot speed are same because I installed on emmc w/ f2fs

DDR 9fffbe1e78 cym 24/02/04-10:09:20,fwver: v1.16
LPDDR4X, 2112MHz
channel[0] BW=16 Col=10 Bk=8 CS0 Row=17 CS=1 Die BW=16 Size=2048MB
channel[1] BW=16 Col=10 Bk=8 CS0 Row=17 CS=1 Die BW=16 Size=2048MB
channel[2] BW=16 Col=10 Bk=8 CS0 Row=17 CS=1 Die BW=16 Size=2048MB
channel[3] BW=16 Col=10 Bk=8 CS0 Row=17 CS=1 Die BW=16 Size=2048MB
Manufacturer ID:0xff
CH0 RX Vref:26.3%, TX Vref:20.8%,0.0%
CH1 RX Vref:28.9%, TX Vref:21.8%,0.0%
CH2 RX Vref:29.7%, TX Vref:20.8%,0.0%
CH3 RX Vref:28.9%, TX Vref:21.8%,0.0%
change to F1: 528MHz
change to F2: 1068MHz
change to F3: 1560MHz
change to F0: 2112MHz
out
U-Boot SPL board init
U-Boot SPL 2017.09-armbian (Jul 02 2024 - 01:23:32)
Trying to boot from MMC2
MMC: no card present
mmc_init: -123, time 0
spl: mmc init failed with error: -123
Trying to boot from MMC1
spl: partition error
Trying fit image at 0x4000 sector
## Verified-boot: 0
## Checking atf-1 0x00040000 ... sha256(a7d1d8d191...) + OK
## Checking uboot 0x00200000 ... sha256(54997c0915...) + OK
## Checking fdt 0x0031e270 ... sha256(906958ed9b...) + OK
## Checking atf-2 0xff100000 ... sha256(4b2065349b...) + OK
## Checking atf-3 0x000f0000 ... sha256(aa71013e72...) + OK
Jumping to U-Boot(0x00200000) via ARM Trusted Firmware(0x00040000)
Total: 82.434/210.596 ms

INFO:    Preloader serial: 2
NOTICE:  BL31: v2.3():v2.3-682-g4ca8a8422:derrick.huang, fwver: v1.45
NOTICE:  BL31: Built : 10:11:21, Dec 27 2023
INFO:    spec: 0x1
INFO:    code: 0x88
INFO:    ext 32k is not valid
INFO:    ddr: stride-en 4CH
INFO:    GICv3 without legacy support detected.
INFO:    ARM GICv3 driver initialized in EL3
INFO:    valid_cpu_msk=0xff bcore0_rst = 0x0, bcore1_rst = 0x0
INFO:    l3 cache partition cfg-0
INFO:    system boots from cpu-hwid-0
INFO:    disable memory repair
WARNING: pmu_power_domain_ctr: 21 mem is up
WARNING: pmu_power_domain_ctr: 21 mem reset ok
INFO:    idle_st=0x21fff, pd_st=0x11fff9, repair_st=0xfff70001
INFO:    dfs DDR fsp_params[0].freq_mhz= 2112MHz
INFO:    dfs DDR fsp_params[1].freq_mhz= 528MHz
INFO:    dfs DDR fsp_params[2].freq_mhz= 1068MHz
INFO:    dfs DDR fsp_params[3].freq_mhz= 1560MHz
INFO:    BL31: Initialising Exception Handling Framework
INFO:    BL31: Initializing runtime services
WARNING: No OPTEE provided by BL2 boot loader, Booting device without OPTEE initialization. SMC`s destined for OPTEE will return SMC_UNK
ERROR:   Error initializing runtime service opteed_fast
INFO:    BL31: Preparing for EL3 exit to normal world
INFO:    Entry point address = 0x200000
INFO:    SPSR = 0x3c9


U-Boot 2017.09-armbian (Jul 02 2024 - 01:23:32 +0000)

Model: Radxa ROCK 5A
MPIDR: 0x81000000
PreSerial: 2, raw, 0xfeb50000
DRAM:  8 GiB
Sysmem: init
Relocation Offset: eda3f000
Relocation fdt: eb9f8f40 - eb9fecd0
CR: M/C/I
Using default environment

DM: v2
mmc@fe2c0000: 1, mmc@fe2e0000: 0
Bootdev(atags): mmc 0
MMC0: HS400 Enhanced Strobe, 200Mhz
PartType: EFI
No misc partition
boot mode: normal
FIT: No boot partition
Failed to load DTB, ret=-2
No valid DTB, ret=-22
Failed to get kernel dtb, ret=-22
Model: Radxa ROCK 5A
MPIDR: 0x81000000
starting USB...
Bus usb@fc800000: USB EHCI 1.00
Bus usb@fc840000: USB OHCI 1.0
Bus usb@fc880000: USB EHCI 1.00
Bus usb@fc8c0000: USB OHCI 1.0
scanning bus usb@fc800000 for devices... 1 USB Device(s) found
scanning bus usb@fc840000 for devices... 1 USB Device(s) found
scanning bus usb@fc880000 for devices... WARN: interface 0 has 2 endpoint descriptor, different from the interface descriptor's value: 1
2 USB Device(s) found
scanning bus usb@fc8c0000 for devices... 1 USB Device(s) found
       scanning usb for storage devices... 0 Storage Device(s) found
No usb mass storage found
CLK: (sync kernel. arm: enter 1008000 KHz, init 1008000 KHz, kernel 0N/A)
  b0pll 24000 KHz
  b1pll 24000 KHz
  lpll 24000 KHz
  v0pll 24000 KHz
  aupll 24000 KHz
  cpll 1500000 KHz
  gpll 1188000 KHz
  npll 24000 KHz
  ppll 1100000 KHz
  aclk_center_root 702000 KHz
  pclk_center_root 100000 KHz
  hclk_center_root 396000 KHz
  aclk_center_low_root 500000 KHz
  aclk_top_root 750000 KHz
  pclk_top_root 100000 KHz
  aclk_low_top_root 396000 KHz
Net:   No ethernet found.
Hit key to stop autoboot('CTRL+C'):  0 

Device 0: unknown device
MMC: no card present
mmc_init: -123, time 0
pcie@fe190000: PCIe Linking... LTSSM is 0x0
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x4
pcie@fe190000: PCIe Linking... LTSSM is 0x4
pcie@fe190000: PCIe Linking... LTSSM is 0x4
pcie@fe190000: PCIe Linking... LTSSM is 0x4
pcie@fe190000: PCIe Linking... LTSSM is 0x4
pcie@fe190000: PCIe Linking... LTSSM is 0x0
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x1
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x1
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x4
pcie@fe190000: PCIe Linking... LTSSM is 0x4
pcie@fe190000: PCIe Linking... LTSSM is 0x1000d
pcie@fe190000: PCIe Linking... LTSSM is 0x13000d
pcie@fe190000: PCIe Linking... LTSSM is 0x13000d
pcie@fe190000: PCIe Linking... LTSSM is 0x13000d
pcie@fe190000: PCIe Linking... LTSSM is 0x3000d
pcie@fe190000: PCIe Linking... LTSSM is 0x3000d
pcie@fe190000: PCIe Linking... LTSSM is 0x30007
pcie@fe190000: PCIe Linking... LTSSM is 0x30007
pcie@fe190000: PCIe Linking... LTSSM is 0x30007
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x0
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x0
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x0
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x1
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe Linking... LTSSM is 0x2
pcie@fe190000: PCIe-0 Link Fail

Device 0: unknown device
pcie@fe190000: failed to find reset-gpios property

Device 1: unknown device
switch to partitions #0, OK
mmc0(part 0) is current device
Scanning mmc 0:1...
Found U-Boot script /boot/boot.scr
4231 bytes read in 3 ms (1.3 MiB/s)
## Executing script at 00500000
Boot script loaded from mmc 0
Testing for existence mmc 0 /boot/armbianEnv.txt ...
Found mmc 0 /boot/armbianEnv.txt - loading mmc 0 0x9000000 /boot/armbianEnv.txt ...
231 bytes read in 2 ms (112.3 KiB/s)
Loaded environment from mmc 0 /boot/armbianEnv.txt into 0x9000000 filesize 0xe7...
Importing into environment ...
armbianEnv.txt imported into environment
15823759 bytes read in 61 ms (247.4 MiB/s)
36770304 bytes read in 132 ms (265.7 MiB/s)
277400 bytes read in 32 ms (8.3 MiB/s)
Trying kaslrseed command... Info: Unknown command can be safely ignored since kaslrseed does not apply to all boards.
Unknown command 'kaslrseed' - try 'help'
Fdt Ramdisk skip relocation
No misc partition
## Loading init Ramdisk from Legacy Image at 0a200000 ...
   Image Name:   uInitrd
   Image Type:   AArch64 Linux RAMDisk Image (gzip compressed)
   Data Size:    15823695 Bytes = 15.1 MiB
   Load Address: 00000000
   Entry Point:  00000000
   Verifying Checksum ... OK
## Flattened Device Tree blob at 0x08300000
   Booting using the fdt blob at 0x08300000
   reserving fdt memory region: addr=8300000 size=aa000
   Using Device Tree in place at 0000000008300000, end 00000000083acfff
## reserved-memory:
  cma: addr=10000000 size=10000000
  ramoops@110000: addr=110000 size=e0000
Adding bank: 0x00200000 - 0xf0000000 (size: 0xefe00000)
Adding bank: 0x100000000 - 0x200000000 (size: 0x100000000)
Adding bank: 0x2f0000000 - 0x300000000 (size: 0x10000000)
Total: 6096.673/6364.514 ms

Starting kernel ...

[    6.367513] Booting Linux on physical CPU 0x0000000000 [0x412fd050]

ColorfulRhino · 2024-07-02T10:20:04Z

Here comes rock-5a-rk3588s_defconfig without patch:
just model are different, boot speed are same because I installed on emmc w/ f2fs

Nice! So it works with rock-5a-rk3588s_defconfig without patch?
The model in the text doesn't matter at all, it's just a text :)

SeeleVolleri · 2024-07-02T11:07:05Z

Here comes rock-5a-rk3588s_defconfig without patch:
just model are different, boot speed are same because I installed on emmc w/ f2fs

Nice! So it works with rock-5a-rk3588s_defconfig without patch? The model in the text doesn't matter at all, it's just a text :)

yeah, works without the patch. But I don't want delete it.

ColorfulRhino · 2024-07-02T11:10:24Z

yeah, works without the patch. But I don't want delete it.

Why? I don't think I understand 😄

SeeleVolleri · 2024-07-02T13:38:58Z

yeah, works without the patch. But I don't want delete it.

Why? I don't think I understand 😄

It's uncomfort to see a wrong name at every boot, and the patch does not affect the rock-5x boards, so I prefer keeping it.
It's just a patch anyway :)

ColorfulRhino · 2024-07-02T14:06:27Z

It's uncomfort to see a wrong name at every boot

I can understand :) In this case, the patch is better suited in your userpatches folder.
So instead of putting it in the folder patch/u-boot/legacy/u-boot-radxa-rk3588/board_firefly-itx-3588j, put it in userpatches/u-boot/legacy/u-boot-radxa-rk3588/board_firefly-itx-3588j

SeeleVolleri · 2024-07-02T14:49:55Z

So instead of putting it in the folder patch/u-boot/legacy/u-boot-radxa-rk3588/board_firefly-itx-3588j, put it in userpatches/u-boot/legacy/u-boot-radxa-rk3588/board_firefly-itx-3588j

But... why? Is because of

I think with the patch in the u-boot patch fodler you will actually change something for the Rock 5A as well, which is not intended. I know it's in its own boot folder, but last time I checked, the boot folder is just cosmetic (to know which patches are from which boards so they can be moved if the board moves) and the patcher will take all patches from all subfolders for all boards.

I build tested, it did not apply the patch to rock-5a. It's the same patch as station-m3 and hilink-h88k.

ColorfulRhino · 2024-07-02T15:11:43Z

But... why? Is because of

No, not because of that, my previous assumption was not correct, I apologize.
But because this is a change for your own preference and will be confusing for others. I also have lots of stuff in my userpatches folder that would not be suited for the general repo 😄 That folder is exactly made for stuff like this :)

It's uncomfort to see a wrong name at every boot

Btw, "Rockchip RK3588 Evaluation Board" is also not the name of the board, it is another board, the rk3588 evb

If you like, you can create a customized defconfig for your board though :)

SeeleVolleri · 2024-07-02T15:23:13Z

Btw, "Rockchip RK3588 Evaluation Board" is also not the name of the board, it is another board, the rk3588 evb

the vendor u-boot name was RK3588 Evb as we mentioned in #6849 (comment)

Apologize for misunderstanding, but
I mean vendor u-boot was the system comes with the board that not compiled and flashed by me, but vendor.

I confirmed the board's original u-boot name was rk3588 Evaluation Board, and the board layout was nearly same as the firefly-itx-3588j.

ColorfulRhino · 2024-07-02T16:02:24Z

Apologize for misunderstanding, but
I mean vendor u-boot was the system comes with the board that not compiled and flashed by me, but vendor.

Ah now I understand what you mean, you mean the uboot it ships with. They are also just using the rk3588_defconfig :)

Try removing this in the rk3588_defconfig:

CONFIG_OPTEE_CLIENT=y
CONFIG_OPTEE_V2=y
CONFIG_OPTEE_ALWAYS_USE_SECURITY_PARTITION=y

SeeleVolleri · 2024-07-02T20:40:26Z

Try removing this in the rk3588_defconfig:

CONFIG_OPTEE_CLIENT=y CONFIG_OPTEE_V2=y CONFIG_OPTEE_ALWAYS_USE_SECURITY_PARTITION=y

I only removed CONFIG_OPTEE_ALWAYS_USE_SECURITY_PARTITION=y, because rock-5b config didn't removed client and v2.

DDR 9fffbe1e78 cym 24/02/04-10:09:20,fwver: v1.16
LPDDR4X, 2112MHz
channel[0] BW=16 Col=10 Bk=8 CS0 Row=17 CS=1 Die BW=16 Size=2048MB
channel[1] BW=16 Col=10 Bk=8 CS0 Row=17 CS=1 Die BW=16 Size=2048MB
channel[2] BW=16 Col=10 Bk=8 CS0 Row=17 CS=1 Die BW=16 Size=2048MB
channel[3] BW=16 Col=10 Bk=8 CS0 Row=17 CS=1 Die BW=16 Size=2048MB
Manufacturer ID:0xff
CH0 RX Vref:26.7%, TX Vref:20.8%,0.0%
CH1 RX Vref:28.5%, TX Vref:21.8%,0.0%
CH2 RX Vref:29.7%, TX Vref:21.8%,0.0%
CH3 RX Vref:28.9%, TX Vref:21.8%,0.0%
change to F1: 528MHz
change to F2: 1068MHz
change to F3: 1560MHz
change to F0: 2112MHz
out
U-Boot SPL board init
U-Boot SPL 2017.09-armbian (Jul 02 2024 - 01:23:32)
Trying to boot from MMC2
spl: partition error
Trying fit image at 0x4000 sector
## Verified-boot: 0
## Checking atf-1 0x00040000 ... sha256(a7d1d8d191...) + OK
## Checking uboot 0x00200000 ... sha256(c22be43b05...) + OK
## Checking fdt 0x0033fb38 ... sha256(912cda2231...) + OK
## Checking atf-2 0xff100000 ... sha256(4b2065349b...) + OK
## Checking atf-3 0x000f0000 ... sha256(aa71013e72...) + OK
Jumping to U-Boot(0x00200000) via ARM Trusted Firmware(0x00040000)
Total: 217.628/346.64 ms

INFO:    Preloader serial: 2
NOTICE:  BL31: v2.3():v2.3-682-g4ca8a8422:derrick.huang, fwver: v1.45
NOTICE:  BL31: Built : 10:11:21, Dec 27 2023
INFO:    spec: 0x1
INFO:    code: 0x88
INFO:    ext 32k is not valid
INFO:    ddr: stride-en 4CH
INFO:    GICv3 without legacy support detected.
INFO:    ARM GICv3 driver initialized in EL3
INFO:    valid_cpu_msk=0xff bcore0_rst = 0x0, bcore1_rst = 0x0
INFO:    l3 cache partition cfg-0
INFO:    system boots from cpu-hwid-0
INFO:    disable memory repair
INFO:    idle_st=0x21fff, pd_st=0x11fff9, repair_st=0xfff70001
INFO:    dfs DDR fsp_params[0].freq_mhz= 2112MHz
INFO:    dfs DDR fsp_params[1].freq_mhz= 528MHz
INFO:    dfs DDR fsp_params[2].freq_mhz= 1068MHz
INFO:    dfs DDR fsp_params[3].freq_mhz= 1560MHz
INFO:    BL31: Initialising Exception Handling Framework
INFO:    BL31: Initializing runtime services
WARNING: No OPTEE provided by BL2 boot loader, Booting device without OPTEE initialization. SMC`s destined for OPTEE will return SMC_UNK
ERROR:   Error initializing runtime service opteed_fast
INFO:    BL31: Preparing for EL3 exit to normal world
INFO:    Entry point address = 0x200000
INFO:    SPSR = 0x3c9


U-Boot 2017.09-armbian (Jul 02 2024 - 19:44:52 +0000)

Model: Rockchip RK3588 Evaluation Board
MPIDR: 0x81000000
PreSerial: 2, raw, 0xfeb50000
DRAM:  8 GiB
Sysmem: init
Relocation Offset: eda1e000
Relocation fdt: eb9fa800 - eb9fecc8
CR: M/C/I
Using default environment

DM: v2
no mmc device at slot 1
mmc@fe2c0000: 1 (SD), mmc@fe2e0000: 0
Bootdev(atags): mmc 1
MMC1: Legacy, 52Mhz
PartType: EFI
No misc partition
boot mode: normal
FIT: No boot partition
Failed to load DTB, ret=-2
No valid DTB, ret=-22
Failed to get kernel dtb, ret=-22
Model: Rockchip RK3588 Evaluation Board
MPIDR: 0x81000000
Minidump: init...
CLK: (sync kernel. arm: enter 1008000 KHz, init 1008000 KHz, kernel 0N/A)
  b0pll 24000 KHz
  b1pll 24000 KHz
  lpll 24000 KHz
  v0pll 24000 KHz
  aupll 24000 KHz
  cpll 1500000 KHz
  gpll 1188000 KHz
  npll 24000 KHz
  ppll 1100000 KHz
  aclk_center_root 702000 KHz
  pclk_center_root 100000 KHz
  hclk_center_root 396000 KHz
  aclk_center_low_root 500000 KHz
  aclk_top_root 750000 KHz
  pclk_top_root 100000 KHz
  aclk_low_top_root 396000 KHz
No misc partition
Net:   No ethernet found.
Hit key to stop autoboot('CTRL+C'):  0 
starting USB...
No working controllers found
USB is stopped. Please issue 'usb start' first.
switch to partitions #0, OK
mmc1 is current device
Scanning mmc 1:1...
Found U-Boot script /boot/boot.scr
4231 bytes read in 14 ms (294.9 KiB/s)
## Executing script at 00500000
Boot script loaded from mmc 1
Testing for existence mmc 1 /boot/armbianEnv.txt ...
Found mmc 1 /boot/armbianEnv.txt - loading mmc 1 0x9000000 /boot/armbianEnv.txt ...
182 bytes read in 12 ms (14.6 KiB/s)
Loaded environment from mmc 1 /boot/armbianEnv.txt into 0x9000000 filesize 0xb6...
Importing into environment ...
armbianEnv.txt imported into environment
15823229 bytes read in 1305 ms (11.6 MiB/s)
36704768 bytes read in 3001 ms (11.7 MiB/s)
277400 bytes read in 100 ms (2.6 MiB/s)
Trying kaslrseed command... Info: Unknown command can be safely ignored since kaslrseed does not apply to all boards.
Unknown command 'kaslrseed' - try 'help'
Fdt Ramdisk skip relocation
No misc partition
## Loading init Ramdisk from Legacy Image at 0a200000 ...
   Image Name:   uInitrd
   Image Type:   AArch64 Linux RAMDisk Image (gzip compressed)
   Data Size:    15823165 Bytes = 15.1 MiB
   Load Address: 00000000
   Entry Point:  00000000
   Verifying Checksum ... OK
## Flattened Device Tree blob at 0x08300000
   Booting using the fdt blob at 0x08300000
   reserving fdt memory region: addr=8300000 size=aa000
   Using Device Tree in place at 0000000008300000, end 00000000083acfff
WARNING: could not set reg FDT_ERR_BADOFFSET.
## reserved-memory:
  cma: addr=10000000 size=10000000
  ramoops@110000: addr=110000 size=e0000
Adding bank: 0x00200000 - 0xf0000000 (size: 0xefe00000)
Adding bank: 0x100000000 - 0x200000000 (size: 0x100000000)
Adding bank: 0x2f0000000 - 0x300000000 (size: 0x10000000)
Total: 5308.567/5707.862 ms

Starting kernel ...

[    5.710885] Booting Linux on physical CPU 0x0000000000 [0x412fd050]

SeeleVolleri · 2024-07-02T20:49:42Z

Hangon I got a mysterious git problem

ColorfulRhino · 2024-07-02T20:51:32Z

I only removed CONFIG_OPTEE_ALWAYS_USE_SECURITY_PARTITION=y, because rock-5b config didn't removed client and v2.

Sounds great if that works! Armbian doesn't use Optee in any way so it doesn't make a difference, but if only removing the one line works, great 👍

Hangon I got a mysterious git problem

We've alll been there at some point, don't worry 😄

SeeleVolleri · 2024-07-02T20:57:39Z

I only removed CONFIG_OPTEE_ALWAYS_USE_SECURITY_PARTITION=y, because rock-5b config didn't removed client and v2.

Sounds great if that works! Armbian doesn't use Optee in any way so it doesn't make a difference, but if only removing the one line works, great 👍

Hangon I got a mysterious git problem

We've alll been there at some point, don't worry 😄

Thanks for encouragement and patience helping me with the patch :)

ColorfulRhino · 2024-07-02T21:28:55Z

Thanks for encouragement and patience helping me with the patch :)

Sure! I'm glad that everything works now.

If you want to go the extra mile, you could rename the patch to something like board-firefly-itx-3588j-disable-optee-security.patch, do a rewrite-uboot-patches (with compile.sh for your board) and add a short description in the patch (see examples in other patches).

I'll let you think about it :) If you don't want to walk the extra mile, it's approved like it currently is 👍

SeeleVolleri · 2024-07-02T21:41:27Z

why not? here you go!

ColorfulRhino

If you aren't annoyed by empty patch subject when patching, then let's go 👍

Thanks for your patience and testing different stuff.

SeeleVolleri · 2024-07-02T21:46:59Z

If you aren't annoyed by empty patch subject when patching, then let's go 👍

oh I forgot that, sry

ColorfulRhino · 2024-07-02T21:49:43Z

oh I forgot that, sry

It's fine you don't need to change it 😄

SeeleVolleri · 2024-07-02T21:49:48Z

Done, everything goes on track as expected and wishes

SeeleVolleri requested a review from igorpecovnik as a code owner July 1, 2024 00:06

github-actions bot added size/small PR with less then 50 lines Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Jul 1, 2024

SeeleVolleri mentioned this pull request Jul 1, 2024

Integrate media boards into the rockchip64 family #6834

Merged

10 tasks

ColorfulRhino reviewed Jul 1, 2024

View reviewed changes

...boot/legacy/u-boot-radxa-rk3588/board_firefly-itx-3588j/uboot-firefly-itx-3588j-config.patch Outdated Show resolved Hide resolved

ColorfulRhino mentioned this pull request Jul 1, 2024

Fix: firefly-itx-3588j: Use mainline u-boot and rename audio output #6851

Closed

5 tasks

SeeleVolleri force-pushed the main branch from 15e495f to 5552fb9 Compare July 1, 2024 14:55

SeeleVolleri requested a review from ColorfulRhino July 1, 2024 15:18

SeeleVolleri closed this Jul 2, 2024

SeeleVolleri force-pushed the main branch from 5552fb9 to 0719c99 Compare July 2, 2024 20:42

SeeleVolleri reopened this Jul 2, 2024

SeeleVolleri force-pushed the main branch from 924e443 to a6999e3 Compare July 2, 2024 21:40

ColorfulRhino previously approved these changes Jul 2, 2024

View reviewed changes

fix: firefly-itx-3588j fails to boot, and audio output

edcb55d

SeeleVolleri dismissed ColorfulRhino’s stale review via edcb55d July 2, 2024 21:49

SeeleVolleri force-pushed the main branch from a6999e3 to edcb55d Compare July 2, 2024 21:49

ColorfulRhino approved these changes Jul 2, 2024

View reviewed changes

ColorfulRhino added Ready to merge Reviewed, tested and ready for merge 08 Milestone: Third quarter release labels Jul 2, 2024

igorpecovnik merged commit 4573778 into armbian:main Jul 3, 2024

amazingfate mentioned this pull request Aug 12, 2024

fix firefly itx3588j u-boot patches not applied #7063

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: firefly-itx-3588j fails to boot, and audio output #6849

fix: firefly-itx-3588j fails to boot, and audio output #6849

SeeleVolleri commented Jul 1, 2024 •

edited

Loading

ColorfulRhino commented Jul 1, 2024

SeeleVolleri commented Jul 1, 2024

ColorfulRhino commented Jul 1, 2024

SeeleVolleri commented Jul 2, 2024 •

edited

Loading

SeeleVolleri commented Jul 2, 2024

SeeleVolleri commented Jul 2, 2024

ColorfulRhino commented Jul 2, 2024 •

edited

Loading

SeeleVolleri commented Jul 2, 2024

ColorfulRhino commented Jul 2, 2024

SeeleVolleri commented Jul 2, 2024

ColorfulRhino commented Jul 2, 2024

SeeleVolleri commented Jul 2, 2024

ColorfulRhino commented Jul 2, 2024

SeeleVolleri commented Jul 2, 2024 •

edited

Loading

ColorfulRhino commented Jul 2, 2024

SeeleVolleri commented Jul 2, 2024

SeeleVolleri commented Jul 2, 2024

ColorfulRhino commented Jul 2, 2024 •

edited

Loading

SeeleVolleri commented Jul 2, 2024

ColorfulRhino commented Jul 2, 2024 •

edited

Loading

SeeleVolleri commented Jul 2, 2024

ColorfulRhino left a comment •

edited

Loading

SeeleVolleri commented Jul 2, 2024

ColorfulRhino commented Jul 2, 2024

SeeleVolleri commented Jul 2, 2024

fix: firefly-itx-3588j fails to boot, and audio output #6849

fix: firefly-itx-3588j fails to boot, and audio output #6849

Conversation

SeeleVolleri commented Jul 1, 2024 • edited Loading

Description

How Has This Been Tested?

Checklist:

ColorfulRhino commented Jul 1, 2024

SeeleVolleri commented Jul 1, 2024

ColorfulRhino commented Jul 1, 2024

SeeleVolleri commented Jul 2, 2024 • edited Loading

SeeleVolleri commented Jul 2, 2024

SeeleVolleri commented Jul 2, 2024

ColorfulRhino commented Jul 2, 2024 • edited Loading

SeeleVolleri commented Jul 2, 2024

ColorfulRhino commented Jul 2, 2024

SeeleVolleri commented Jul 2, 2024

ColorfulRhino commented Jul 2, 2024

SeeleVolleri commented Jul 2, 2024

ColorfulRhino commented Jul 2, 2024

SeeleVolleri commented Jul 2, 2024 • edited Loading

ColorfulRhino commented Jul 2, 2024

SeeleVolleri commented Jul 2, 2024

SeeleVolleri commented Jul 2, 2024

ColorfulRhino commented Jul 2, 2024 • edited Loading

SeeleVolleri commented Jul 2, 2024

ColorfulRhino commented Jul 2, 2024 • edited Loading

SeeleVolleri commented Jul 2, 2024

ColorfulRhino left a comment • edited Loading

Choose a reason for hiding this comment

SeeleVolleri commented Jul 2, 2024

ColorfulRhino commented Jul 2, 2024

SeeleVolleri commented Jul 2, 2024

SeeleVolleri commented Jul 1, 2024 •

edited

Loading

SeeleVolleri commented Jul 2, 2024 •

edited

Loading

ColorfulRhino commented Jul 2, 2024 •

edited

Loading

SeeleVolleri commented Jul 2, 2024 •

edited

Loading

ColorfulRhino commented Jul 2, 2024 •

edited

Loading

ColorfulRhino commented Jul 2, 2024 •

edited

Loading

ColorfulRhino left a comment •

edited

Loading