fix(dialogue editor): no longer fires an error when deleting list items

Action and condition lists were firing false positive errors due to a known Unity bug. The
re-orderable list is trying to update the display before the asset database can refresh the assets.
Thereby triggering a false positive error that the asset cannot be displayed.

Author: ashblue

Assets/com.fluid.dialogue/Editor/Inspectors/NodeDataBase/NodeDataBaseEditor.cs

@@ -31,9 +31,13 @@ public override void OnInspectorGUI () {
             base.OnInspectorGUI();
             SpellCheckText();
 
+            serializedObject.Update();
+
             _conditions.Update();
             _enterActions?.Update();
             _exitActions?.Update();
+
+            serializedObject.ApplyModifiedProperties();
         }
 
         private void SpellCheckText () {

Assets/com.fluid.dialogue/Editor/Inspectors/NodeDataBase/SortableLists/ActionsSortableList.cs

@@ -11,11 +11,11 @@ public class ActionsSortableList : SortableListBase {
         private readonly NestedDataCrud<ActionDataBase> _actionCrud;
 
         private static TypesToMenu<ActionDataBase> ActionTypes =>
-            _actionTypes ?? (_actionTypes = new TypesToMenu<ActionDataBase>());
+            _actionTypes ??= new TypesToMenu<ActionDataBase>();
 
         public ActionsSortableList (Editor editor, string property, NodeDataBase node, List<ActionDataBase> actions)
             : base(editor, property) {
-            _soPrinter = new ScriptableObjectListPrinter(_serializedProp);
+            _soPrinter = new ScriptableObjectListPrinter(editor.serializedObject.FindProperty(property));
             _actionCrud = new NestedDataCrud<ActionDataBase>(node, actions, ActionTypes);
 
             _list.drawElementCallback = _soPrinter.DrawScriptableObject;

Assets/com.fluid.dialogue/Editor/Inspectors/NodeDataBase/SortableLists/ConditionSortableList.cs

@@ -11,11 +11,11 @@ public class ConditionSortableList : SortableListBase {
         private readonly NestedDataCrud<ConditionDataBase> _conditionCrud;
 
         private static TypesToMenu<ConditionDataBase> ConditionTypes =>
-            _conditionTypes ?? (_conditionTypes = new TypesToMenu<ConditionDataBase>());
+            _conditionTypes ??= new TypesToMenu<ConditionDataBase>();
 
         public ConditionSortableList (Editor editor, string property, NodeDataBase node, List<ConditionDataBase> conditions)
             : base(editor, property) {
-            _soPrinter = new ScriptableObjectListPrinter(_serializedProp);
+            _soPrinter = new ScriptableObjectListPrinter(editor.serializedObject.FindProperty(property));
             _conditionCrud = new NestedDataCrud<ConditionDataBase>(node, conditions, ConditionTypes);
 
             _list.drawElementCallback = _soPrinter.DrawScriptableObject;

Assets/com.fluid.dialogue/Editor/Inspectors/NodeDataBase/SortableLists/NestedDataCrud.cs

@@ -54,6 +54,7 @@ private void CreateItem (Type type) {
 
             Undo.CollapseUndoOperations(Undo.GetCurrentGroup());
             AssetDatabase.SaveAssets();
+            AssetDatabase.Refresh();
         }
 
         public void DeleteItem (ReorderableList list) {
@@ -70,7 +71,15 @@ public void DeleteItem (ReorderableList list) {
             Undo.DestroyObjectImmediate(listItem);
 
             Undo.CollapseUndoOperations(Undo.GetCurrentGroup());
-            AssetDatabase.SaveAssets();
+
+            // Forcibly refresh the serialized object to prevent an immediate crash
+            list.serializedProperty.serializedObject.Update();
+
+            // We must refresh instead of save. Otherwise the re-orderable list will crash due to an editor bug
+            AssetDatabase.Refresh();
+
+            // Mark the asset dirty so the changes are saved
+            EditorUtility.SetDirty(graph);
         }
     }
 }

Assets/com.fluid.dialogue/Editor/Inspectors/SortableListBase.cs

@@ -4,42 +4,34 @@
 
 namespace CleverCrow.Fluid.Dialogues.Editors.Inspectors {
     public class SortableListBase {
-        protected readonly Editor _editor;
-        protected readonly ReorderableList _list;
-        protected readonly SerializedObject _serializedObject;
-        protected readonly SerializedProperty _serializedProp;
+        protected ReorderableList _list;
+        bool _skipFrame;
 
         public SortableListBase (Editor editor, string property) {
             if (editor == null) {
                 Debug.LogError("Editor cannot be null");
                 return;
             }
 
-            _editor = editor;
-            _serializedProp = _editor.serializedObject.FindProperty(property);
-            _serializedObject = _editor.serializedObject;
-
-            if (_serializedProp == null) {
+            var prop = editor.serializedObject.FindProperty(property);
+            if (prop == null) {
                 Debug.LogErrorFormat("Could not find property {0}", property);
                 return;
             }
 
             _list = new ReorderableList(
-                _serializedObject,
-                _serializedProp,
+                editor.serializedObject,
+                prop,
                 true, true, true, true);
 
+            var title = prop.displayName;
             _list.drawHeaderCallback = rect => {
-                EditorGUI.LabelField(rect, _serializedProp.displayName);
+                EditorGUI.LabelField(rect, title);
             };
         }
 
         public void Update () {
-            _serializedObject.Update();
-
-            _list?.DoLayoutList();
-
-            _serializedObject.ApplyModifiedProperties();
+            if (_list != null) _list.DoLayoutList();
         }
     }
 }