Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "v" from the Ruff version number in link to release notes #92

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Remove "v" from the Ruff version number in link to release notes #92

merged 1 commit into from
Jun 28, 2024

Conversation

Tenzer
Copy link
Contributor

@Tenzer Tenzer commented Jun 28, 2024

Summary

Starting with version 0.5.0 of Ruff, the release/tag name doesn't have a leading "v". This has broken the link to the release notes that get added to the release notes for the pre-commit hook.

This fixes it by stripping any "v" from the version number string.

See #91.

Test Plan

Tested in a bash shell:

bash-5.2$ TAG_NAME=v0.5.0
bash-5.2$ echo ${TAG_NAME/v}
0.5.0

Will otherwise have to be tested on the next Ruff release.

Starting with version 0.5.0 of Ruff, the release/tag name doesn't have a
leading "v". This has broken the link to the release notes that get added to
the release notes for the pre-commit hook.

This fixes it by stripping any "v" from the version number string.
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh merged commit 987f9d7 into astral-sh:main Jun 28, 2024
@CoderJoshDK
Copy link
Contributor

The actual fix is to remove v from the tag. I can do that alongside the changes in astral-sh/uv-pre-commit#11. Just need to know if I am clear to make the changes from that PR in this repo too (all changes made after notes, if there are any)

@Tenzer
Copy link
Contributor Author

Tenzer commented Jun 29, 2024

I didn't want to change the format of the tag created in this repository, in case it would break how pre-commit autouodate works.

Have you checked that it still works and picks up the latest version if the "v" prefix is removed?

@CoderJoshDK
Copy link
Contributor

Very understandable concern. pre-commit autoupdate grabs the FETCH_HEAD's tag. (The command is slightly more complicated; but it basically is git describe FETCH_HEAD --tags --abbrev=0)

But more generally, we know that it doesn't require the v, because uv-pre-commit doesn't have a v. (astral-sh/uv-pre-commit#5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants