Skip to content

[red-knot] bump Salsa version #17176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

[red-knot] bump Salsa version #17176

merged 1 commit into from
Apr 3, 2025

Conversation

carljm
Copy link
Contributor

@carljm carljm commented Apr 3, 2025

Update to latest Salsa main branch, so as to get a baseline for measuring the perf effect of salsa-rs/salsa#786 on red-knot in isolation from other recent changes in Salsa main branch.

Copy link
Contributor

github-actions bot commented Apr 3, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@carljm carljm marked this pull request as ready for review April 3, 2025 14:29
@carljm carljm enabled auto-merge (squash) April 3, 2025 14:30
@carljm carljm merged commit c1f93a7 into main Apr 3, 2025
19 checks passed
@carljm carljm deleted the cjm/bumpsalsa branch April 3, 2025 14:31
@carljm carljm changed the title [DO NOT LAND] bump Salsa version [red-knot] bump Salsa version Apr 3, 2025
Copy link

codspeed-hq bot commented Apr 3, 2025

CodSpeed Performance Report

Merging #17176 will improve performances by 6.55%

Comparing cjm/bumpsalsa (d235812) with main (6e2b8f9)

Summary

⚡ 1 improvements
✅ 31 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
red_knot_check_file[incremental] 5.1 ms 4.8 ms +6.55%

@carljm carljm added the ty Multi-file analysis & type inference label Apr 3, 2025
dcreager added a commit that referenced this pull request Apr 3, 2025
* origin/main:
  [red-knot] Add `Type::TypeVar` variant (#17102)
  [red-knot] update to latest Salsa with fixpoint caching fix (#17179)
  Upgrade to Rust 1.86 and bump MSRV to 1.84 (#17171)
  [red-knot] Avoid unresolved-reference in unreachable code (#17169)
  Fix relative import resolution in `site-packages` packages when the `site-packages` search path is a subdirectory of the first-party search path (#17178)
  [DO NOT LAND] bump Salsa version (#17176)
  [syntax-errors] Detect duplicate keys in `match` mapping patterns (#17129)
maxmynter pushed a commit to maxmynter/ruff that referenced this pull request Apr 3, 2025
Update to latest Salsa main branch, so as to get a baseline for
measuring the perf effect of salsa-rs/salsa#786
on red-knot in isolation from other recent changes in Salsa main branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ty Multi-file analysis & type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant