Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: deprecate band from Gaia.load_data() #3278

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Mar 29, 2025

It has no effect on upstream query any more, thus we should remove it (but with a deprecation, so it doesn't break user code straight away).

Closes #3248

@bsipocz bsipocz added the gaia label Mar 29, 2025
@bsipocz bsipocz added this to the v0.4.11 milestone Mar 29, 2025
@bsipocz bsipocz requested a review from jespinosaar March 29, 2025 00:58
Copy link

codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.38%. Comparing base (af2d6f4) to head (f021816).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3278   +/-   ##
=======================================
  Coverage   69.37%   69.38%           
=======================================
  Files         232      232           
  Lines       19686    19682    -4     
=======================================
- Hits        13657    13656    -1     
+ Misses       6029     6026    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAINT: deprecate band parameter for gaia
1 participant