[AXON-257] Added {{{username}}} keyword for Jira's custom branch template #315
Conversation
marcomura
requested review from
bwieger-atlassian-com,
sdzh-atlassian,
cabella-dot,
akalia-atlassian and
pastelsky
as code owners
| @@ -38,13 +42,24 @@ export const StartWorkSettings: React.FunctionComponent<StartWorkSettings> = ({ | |||
| }, [changes, controller]); | |||
|
|
|||
| const getTemplatePreview = useCallback(() => { | |||
| const usernameBase = 'trevinavery'; | |||
There was a problem hiding this comment.
@TrevinAvery double checking if you are ok with this :)
There was a problem hiding this comment.
Sure. I don't mind the credit. Haha.
| E.g. <code>{'{{{username}}}/{{{prefix}}}{{{issueKey}}}-{{{summary}}}'}</code> will generate | ||
| something of the format:{' '} | ||
| <code> | ||
| {'trevinavery/feature/VSCODE-1005-allow-users-to-configure-the-way-branch-name-is-co'} |
There was a problem hiding this comment.
@TrevinAvery double checking if you are ok with this :)
is this the same as the bitbucket username? I don't think it is, and I think it would be better to retrieve the username assigned in the BB instance. I know my own BB username is different than my email address. email: jeremy.fiel@company.com |
|
@marcomura can you clarify my concern with the git user info rather than calling the users api for jira or bb? |
|
hi @jeremyfiel, I believe that this change should be changed as following:
Unfortunately, I didn't have time to apply the required changes yet. FYI: @TrevinAvery |
What Is This Change?
Addresses #250 .
This change adds the
{{{username}}}keyword for building the Jira's custom branch template.E.g.:
{{{username}}}/{{{prefix}}}}{{{issuekey}}}-{{{{summary}}}}The username is retrieved from the 'username' part of the git's
user.emailconfiguration.This change also fixes the
{{{prefix}}}not working correctly.How Has This Been Tested?
Basic checks:
npm run lintnpm run testAdvanced checks:
Recommendations: