AXON-379: Atlassian Notifications - Bitbucket and Jira Comments #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger to handle by Credential and by product removal of notifications
…ON-379-atlassian-notifications
bwieger-atlassian-com
requested review from
sdzh-atlassian,
cabella-dot,
marcomura,
akalia-atlassian and
pastelsky
as code owners
…ON-379-atlassian-notifications
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ON-379-atlassian-notifications
…/atlassian/atlascode into AXON-379-atlassian-notifications
| @@ -6,7 +6,7 @@ case `uname -s` in | |||
| *) CODEPATH=~/.config/Code;; | |||
| esac | |||
|
|
|||
| OLDSTATE=`sqlite3 ${CODEPATH}/User/globalStorage/state.vscdb 'select value from ItemTable where key = "atlassian.atlascode";'` | |||
| OLDSTATE=`sqlite3 "${CODEPATH}/User/globalStorage/state.vscdb" 'select value from ItemTable where key = "atlassian.atlascode";'` | |||
There was a problem hiding this comment.
This is just fixing up an old util script
| const sites = Container.siteManager.getSitesAvailable(product); | ||
| const uniquelyCredentialedSites = Array.from(new Map(sites.map((site) => [site.credentialId, site])).values()); | ||
|
|
||
| const authInfos = await Promise.all(uniquelyCredentialedSites.map((site) => this.getAuthInfo(site, true))); |
There was a problem hiding this comment.
Interesting note here: the getAuthInfo function call doesn't refresh the token itself.
| if (productAuths) { | ||
| userId = productAuths.get(site.credentialId)?.user.id || ''; |
There was a problem hiding this comment.
Needed to clear out notification details
| const repoUrl = url.slice(0, url.indexOf('/pull-requests')); | ||
| const prUrlPath = Uri.parse(url).path; | ||
| const prId = prUrlPath.slice(prUrlPath.lastIndexOf('/') + 1); | ||
| const prId = prUrlPath.split('/pull-requests/')[1]?.split('/')[0]; |
There was a problem hiding this comment.
In some case the URL might come with extra stuff at the end.
bwieger-atlassian-com
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is This Change?
https://www.loom.com/share/dc633545b1cc464c84d6af13df849da2?sid=11a5116c-5d26-484e-a482-21ffc24f8ad1
How Has This Been Tested?
Basic checks:
npm run lintnpm run testAdvanced checks:
Recommendations: