Hiding the exposed data for Deferred Installation Flow (#2523)

* - Masking information in the deferred screen

* - Cleanup

Author: krazziekay

src/rest/routes/deferred/deferred-request-parse.test.ts

@@ -49,8 +49,8 @@ describe("Checking the deferred request parsing route", () => {
 				.get(`/rest/app/cloud/deferred/parse/${VALID_REQUEST_ID}`);
 			expect(resp.status).toEqual(200);
 			expect(resp.body).toMatchObject({
-				"jiraHost": "https://test-atlassian-instance.atlassian.net",
-				"orgName": "custom-orgName"
+				"jiraHost": "https://t*********************e.atlassian.net",
+				"orgName": "c************e"
 			});
 		});
 	});

src/rest/routes/deferred/deferred-request-parse.ts

@@ -5,6 +5,7 @@ import {
 } from "services/subscription-deferred-install-service";
 import { InvalidArgumentError } from "config/errors";
 import { DeferralParsedRequest } from "rest-interfaces";
+import maskString from "utils/mask-string";
 
 export const DeferredRequestParseRoute = errorWrapper("ParseRequestId", async function DeferredRequestParseRoute(req: Request, res: Response<DeferralParsedRequest>) {
 	const requestId = req.params.requestId;
@@ -13,10 +14,17 @@ export const DeferredRequestParseRoute = errorWrapper("ParseRequestId", async fu
 		throw new InvalidArgumentError("Missing requestId in query");
 	}
 
-	const deferredInstallPayload = await extractSubscriptionDeferredInstallPayload(requestId);
+	const { jiraHost, orgName } = await extractSubscriptionDeferredInstallPayload(requestId);
+	if (!jiraHost) {
+		throw new Error("No jiraHost");
+	}
+
+	const host = new URL(jiraHost).hostname.split(".")[0];
+	const maskedHost = maskString(host);
+	const maskedOrgName = maskString(orgName);
 
 	res.status(200).send({
-		jiraHost: deferredInstallPayload.jiraHost as string,
-		orgName: deferredInstallPayload.orgName
+		jiraHost: `https://${maskedHost}.atlassian.net`,
+		orgName: maskedOrgName
 	});
 });

src/util/mask-string.test.ts

@@ -0,0 +1,26 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
+import maskString from "utils/mask-string";
+
+const testData = [
+	{
+		actual: "nico-robin",
+		result: "n********n"
+	},
+	{
+		actual: "boa-hancock",
+		result: "b*********k"
+	},
+	{
+		actual: "nerfertari-vivi",
+		result: "n*************i"
+	}
+];
+
+describe("Test for mask string", () => {
+	testData.forEach(datum => {
+		const { actual, result } = datum;
+		it(`Testing ${actual} for ${result}`, () => {
+			expect(maskString(actual)).toBe(result);
+		});
+	});
+});

src/util/mask-string.ts

@@ -0,0 +1,3 @@
+const maskString = (str: string) => str[0] + str.slice(1).replace(/.(?!$)/g, "*");
+
+export default  maskString;