Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction to support Julia 1.10 #1125

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Correction to support Julia 1.10 #1125

merged 1 commit into from
Jan 31, 2024

Conversation

rrsadykov
Copy link
Collaborator

Also putting back the tests with the latest Julia version.
Closes #1124.
Closes #1118.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1064d8) 86.51% compared to head (1cf332a) 86.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1125      +/-   ##
==========================================
+ Coverage   86.51%   86.78%   +0.27%     
==========================================
  Files          85       88       +3     
  Lines        7556     7577      +21     
==========================================
+ Hits         6537     6576      +39     
+ Misses       1019     1001      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rrsadykov
Copy link
Collaborator Author

Waiting for confirmation from Guillaume.

@rrsadykov rrsadykov merged commit ce28df4 into master Jan 31, 2024
6 checks passed
@rrsadykov rrsadykov deleted the working_1.10 branch January 31, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion error, explore.jl type expected an Int32 and got an Int64 Tests do not pass in Julia 1.10
2 participants