Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmaintained? #52

Open
gagarine opened this issue Oct 28, 2024 · 25 comments
Open

Unmaintained? #52

gagarine opened this issue Oct 28, 2024 · 25 comments

Comments

@gagarine
Copy link

This plugin appears to be unmaintained, with the last commit made five months ago.

Given the security sensitivity of this plugin, we would greatly appreciate any clarification on its current status.

Thank you!

@au2001
Copy link
Owner

au2001 commented Oct 28, 2024

Hi, Apple is going to release an official version soon
I will see if it's worth it to continue working on new features then
In the mean time, security fixes are still definitely taken seriously

@romanmgelman
Copy link

Source? I really appreciate all the work you and contributors have done for us Mac Firefox users!

@gagarine
Copy link
Author

gagarine commented Oct 28, 2024 via email

@au2001
Copy link
Owner

au2001 commented Oct 28, 2024

Source?

Screenshot 2024-10-28 at 20 49 56

@romanmgelman
Copy link

merci!

@the-gray-ghost
Copy link

Any idea why your add-on is now showing up as the official Apple one in the Firefox Add-On store?

https://addons.mozilla.org/en-US/firefox/user/10200780/

@regulskimichal
Copy link

Based on the data from webarchive, it looks to me like it has been handed over to Apple.
On the other hand, it is relatively easy to adapt their CRX from Chrome to XPI. As a downside, if anyone will try it on their own:

  • change manifest.json by removing incompatible properties and switching from
"background": {
  "service_worker": "background.js"
}

to

"background": {
  "scripts": ["background.js"]
}
  • add extension id to manifest.json:
"browser_specific_settings": {
  "gecko": {
    "id": "password-manager-firefox-extension@apple.com"
  }
}
  • they need to setup NativeMessagingHosts according to the platform, or use scripts from scripts/installation folder
  • load extension to Firefox Developer Edition/ESR with disabled feature-flag xpinstall.signatures.required

@au2001
Copy link
Owner

au2001 commented Nov 12, 2024

@the-gray-ghost Any idea why your add-on is now showing up as the official Apple one in the Firefox Add-On store?

Quoting from Reddit:

Yes Apple did reach out to me through Mozilla
They plan on releasing an official version soon™
For technical reasons, my extension is the only one which can read iCloud Passwords
So I accepted to transfer it to them

The source code is still available on GitHub, and if Apple's version isn't good enough I will re-publish it under a different listing and continue to maintain it
Otherwise I'll update the GitHub readme and archive the repository

@au2001
Copy link
Owner

au2001 commented Nov 12, 2024

@regulskimichal On the other hand, it is relatively easy to adapt their CRX from Chrome to XPI.

Manually porting the Chrome extension is not necessary
The (now official) extension on AMO still works fine
I specifically asked Apple that there be no downtime so that all Firefox users can continue to use iCloud Passwords

Although your steps should also work for people who do not wish to trust the code from this repository

@regulskimichal
Copy link

I missed one feature - 2FA codes, although I saw your branch and I truly appreciate your effort to make iCloud Passwords for everyone

@biotomed
Copy link

I tried to automatically (and manually) update the registry and json files as seen in your install scripts to get the plug-in working for Windows with the new iCloud app, but unfortunately that didn’t work. Is there no way right now to get it working for windows? How long do you think I have to wait until Apple or you release a working option? :)

@leftbones
Copy link

I'm hoping the official one doesn't require entering a code to make it work, I was surprised to see that the same thing is required for the Chrome extension, which I thought was official.

@au2001
Copy link
Owner

au2001 commented Nov 22, 2024

Is there no way right now to get it working for windows?

There is no documented way right now unfortunately

How long do you think I have to wait until Apple or you release a working option? :)

I don't have much info on their timeline either

I'm hoping the official one doesn't require entering a code to make it work, I was surprised to see that the same thing is required for the Chrome extension, which I thought was official.

The Chrome and Edge extensions are official
They require entering a code to avoid other apps reading your accounts
I do not see Apple changing this behavior any time soon, but that's just my opinion
The most probable option IMO would be a first-party iCloud Keychain integration in Firefox itself one day

@101Dude
Copy link

101Dude commented Nov 23, 2024

I suggest no one install this until it's 100% clear who owns the page on Mozilla.

The Mozilla Plugin page for this is very phishy

Reads:

iCloud Passwords by Apple Inc.

and also says:

This extension is not endorsed in any way by Apple Inc.
iCloud, iCloud Keychain, and macOS are trademarks of Apple Inc., registered in the U.S. and other countries and regions.

Even more odd is why Apple would produce iCloud Keychain when they now are integrating their Passwords.app functionality into browsers.

@m1ten
Copy link

m1ten commented Nov 23, 2024

and also says:

This extension is not endorsed in any way by Apple Inc.
iCloud, iCloud Keychain, and macOS are trademarks of Apple Inc., registered in the U.S. and other countries and regions.

I’m quite certain that’s inherited from the initial listing. They haven’t made any updates since then, so in a sense, it’s “not endorsed.”

@hakusaro
Copy link

Even more odd is why Apple would produce iCloud Keychain when they now are integrating their Passwords.app functionality into browsers.

@101Dude actually, this is the way that Apple usually integrates with third-party browsers. They just publish an extension that can talk to the official Passwords app.

@au2001 thank you for all your hard work, and I really hope Apple at least paid you a little for this.

@au2001
Copy link
Owner

au2001 commented Nov 24, 2024

I suggest no one install this until it's 100% clear who owns the page on Mozilla.

The Mozilla Plugin page for this is very phishy

Apple owns the listing, I own the code

If you do not trust the code, then you should wait for Apple to release their own

I’m quite certain that’s inherited from the initial listing. They haven’t made any updates since then, so in a sense, it’s “not endorsed.”

Yes, precisely

@101Dude actually, this is the way that Apple usually integrates with third-party browsers. They just publish an extension that can talk to the official Passwords app.

Right, Apple can only integrate their new Passwords.app through an (my) extension, like they do on Chrome or for iCloud Bookmarks

Having first-party integration in Firefox requires Mozilla to do it, or at least Apple to work with them

@au2001 thank you for all your hard work, and I really hope Apple at least paid you a little for this.

Unfortunately not, I suggested a $1 one-time GitHub sponsorship as acknowledgement before the transfer but didn't get an answer

@hakusaro
Copy link

Unfortunately not, I suggested a $1 one-time GitHub sponsorship as acknowledgement before the transfer but didn't get an answer

Typical. I'm sorry but I don't have a lot of free cash flow (I just moved), but please enjoy a small thankyou, because I really appreciate this extension!

@ctrlMarcio
Copy link

Well, now it simply doesn't work (at least for me)

An unknown error occurred. Make sure you have the latest version of the extension installed. If the error persists, please try restarting Firefox.

IDK if it's because of the new FF version, but I guess it won't be updated.

@au2001
Copy link
Owner

au2001 commented Dec 2, 2024

Typical. I'm sorry but I don't have a lot of free cash flow (I just moved), but please enjoy a small thankyou, because I really appreciate this extension!

Thanks, it means a lot! I'm happy this extension has proven useful for more than just my own use

Well, now it simply doesn't work (at least for me)

Are you using Windows perhaps? Sounds like #40

@ctrlMarcio
Copy link

Are you using Windows perhaps? Sounds like #40

Yep, sorry. Answer in #38 worked out for me.

@MrMcFly2k
Copy link

Finally, Apple released its official iCloud Passwords Firefox extension:

https://addons.mozilla.org/en-US/firefox/addon/icloud-passwords/

@ayndqy
Copy link

ayndqy commented Dec 4, 2024

Thanks for your work! It was a pleasure to use your extension until the official one came out.

@MrMcFly2k
Copy link

@au2001 could you please confirm if it has been handed over to Apple?

https://addons.mozilla.org/en-US/firefox/addon/icloud-passwords/

@au2001
Copy link
Owner

au2001 commented Dec 4, 2024

@au2001 could you please confirm if it has been handed over to Apple?

Yes, Apple is now the sole owner/maintainer of the iCloud Passwords extension on Firefox
Their version is not linked in any way to this repo anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

14 participants