fix: ⬆️ add compatibility for numpy>2.0 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the fix. The current requirements.txt file limits the numpy version to >=1.6 and <2.0. Can you please update the requirement file in this fix, too? |
due to numpy>2.0 np.complex_ is deprcated
|
Sure, I updated requirements.txt. |
|
The package cannot be successfully built yet. The function coherence_error() must also be updated (complex_ → complex128). |
|
Ok, I have fixed all np.complex_ to np.complex128. I have also run the test and built the package locally using Python 3.11. I think there is no problem. |
|
The package can now be built using Python 3.8-3.12. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In numpy>2.0 np.complex_ is deprcated please see namespace change