Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bai19 #73

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

trongtuyen271199
Copy link

Review dùm em class LoginIceHrmTest. Em có tách ra 2 bộ data cho 2 case là success và failse nhưng run báo lỗi em chưa fix được.
Do em tách ra để chạy file Smoke.XML và file Regrestion.XML ( theo anh Khánh có chỉ thì smoke chỉ để happy case nên em mới tách riêng 2 dataprovider là success và false )

@letienson987
Copy link

cmt: 5
"Hi ,

You are providing an incorrect PR link.

Here is an example of a correct pull request.

Plz resubmit with the correct link.

Example (DO NOT USE):[https://github.com/your-github-username/automation-course-template/pull/id_of_your PR]

@trongtuyen271199
Copy link
Author

trongtuyen271199#4

@letienson987
Copy link

letienson987 commented Nov 18, 2024

Hi @trongtuyen271199
I have checked your homework.
Cause of error:
In line 33, You declared the testdata array with a size of new Object[3][3], meaning it only has 3 rows (index 0 to 2). However, in the value assignment, you attempted to access testdata[3], which caused an error.
hint:
you can fix this error like this image
https://share.zight.com/v1uqZob1

Best wishes from the Automation Test Pro team (Son Le, son.le@automationtestpro.com)

@letienson987
Copy link

//Comment from HW team,
Hello, @trongtuyen271199
Your homework has been reviewed.
You are doing great! Keep up the good work!
https://share.zight.com/Apuq5wOG

Best wishes from the Automation Test Pro team (Son Le, son.le@automationtestpro.com)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants