Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on the side lidars #51

Closed
xmfcx opened this issue Apr 16, 2024 · 2 comments
Closed

Turn on the side lidars #51

xmfcx opened this issue Apr 16, 2024 · 2 comments
Assignees
Labels
type:new-feature New functionalities or additions, feature requests.

Comments

@xmfcx
Copy link

xmfcx commented Apr 16, 2024

In the AWSIM Autoware configuration and in the simulation, there are 2 side lidars. With the lidar on top, there are 3 VLP16s on the vehicle.

In the old HDRP, due to performance issues side lidars were turned off.

Let's turn them back on.

Also @brkay54 tested the side lidars and will share some problems they have.

Probably if we just move(translate) them slightly to the sides, the problems will be fixed.

@xmfcx xmfcx changed the title Turn on 2 side lidars too Turn on the side lidars too Apr 16, 2024
@xmfcx xmfcx changed the title Turn on the side lidars too Turn on the side lidars Apr 16, 2024
@xmfcx xmfcx added the type:new-feature New functionalities or additions, feature requests. label Apr 17, 2024
@brkay54
Copy link
Member

brkay54 commented Apr 18, 2024

The current left and right lidar output is shown here. My concerns are:

  • side lidars are not symmetrical
  • they can not see the front of the vehicle
    3-2

We made some draft changes, the points on the vehicle were increased but the side lidars can see the front. It is just a draft setup we can improve it.
3-1

Sensor positions before change:

  velodyne_left_base_link:
    x: 0.0
    y: 0.56362
    z: -0.30555
    roll: -0.02
    pitch: 0.71
    yaw: 1.575
  velodyne_right_base_link:
    x: 0.0
    y: -0.56362
    z: -0.30555
    roll: -0.01
    pitch: 0.71
    yaw: -1.580

Sensor positions after change:

  velodyne_left_base_link:
    x: 0.0
    y: 0.6
    z: -0.30555
    roll: -0.020000007151
    pitch: 0.70999994
    yaw: 1.5749851
  velodyne_right_base_link:
    x: 0.0
    y: -0.6
    z: -0.30555
    roll: -0.020000007151
    pitch: 0.70999994
    yaw: -1.5749851

@mozhoku
Copy link
Collaborator

mozhoku commented Apr 18, 2024

Okay I've made some changes and opened a PR on the autoware_individual_params repo here:

In the AWSIM side I will update the lidars and will look like this:

Before:
image

After:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

No branches or pull requests

3 participants