Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update perception pipeline node diagram #570

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Jun 10, 2024

Description

image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen force-pushed the chore/update_node_diag_low_intensity_filter branch from 9c75322 to bb0a4fa Compare June 10, 2024 02:46
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen marked this pull request as ready for review June 10, 2024 03:02
Copy link

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen changed the title update perception pipeline node diagram fix: update perception pipeline node diagram Jun 12, 2024
@badai-nguyen badai-nguyen merged commit b772d90 into autowarefoundation:main Jun 12, 2024
10 of 11 checks passed
@badai-nguyen badai-nguyen deleted the chore/update_node_diag_low_intensity_filter branch June 12, 2024 06:36
@TimS120
Copy link

TimS120 commented Jun 15, 2024

Hey, since it is possible for you to push something with pull requests here, would it be possible to at least move the groups from this pull request (#558) behind the elements of the groups itselfe (lidar sensing pipeline-, gnss sensing pipeline-, imu sensing pipeline- and parking-group)? [That's only work of a few minutes.]
If you did that, I would close my pull request, since it's probably not possible to merge that anyways...
I would highly appreciate that, so thanks a lot and have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants