Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(coding_guidelines): match the example to the actual autoware_gnss_poser #603

Conversation

TaikiYamada4
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 commented Sep 2, 2024

Description

In the coding guidelines, autoware_gnss_poser is used as an example.

However, there are some lines that mismatch to the actual autoware_gnss_poser, so I fixed them in this PR.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
@TaikiYamada4 TaikiYamada4 self-assigned this Sep 2, 2024
@TaikiYamada4 TaikiYamada4 marked this pull request as ready for review September 2, 2024 03:49
@SakodaShintaro
Copy link
Contributor

One of CI checks failed. But I think it is not related to this PR.

  ERROR: 1 dead links found in docs/how-to-guides/integrating-autoware/launch-autoware/index.md !
  [✖] https://autowarefoundation.github.io/autoware.universe/main/perception/traffic_light_fine_detector/ → Status: 404

I will continue to review this PR.

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me

@TaikiYamada4 TaikiYamada4 merged commit 9a1c6e9 into autowarefoundation:main Sep 2, 2024
10 of 11 checks passed
@TaikiYamada4 TaikiYamada4 deleted the chore/gnss_poser/match_universe_code branch September 2, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants