-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_test_utils): porting autoware_test_utils from universe to core #172
feat(autoware_test_utils): porting autoware_test_utils from universe to core #172
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
This pr depends on the new ported package "autoware_utils": autowarefoundation/autoware_utils#23 and "autoware_internal_msgs": autowarefoundation/autoware_internal_msgs#45 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jncr gen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this package is only used during testing, as its name suggests, it shouldn’t be in the common
directory. I think it would be better to create a tests
directory and move it there just like the demos
directory.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
===========================================
- Coverage 78.75% 36.94% -41.82%
===========================================
Files 11 29 +18
Lines 193 1164 +971
Branches 73 523 +450
===========================================
+ Hits 152 430 +278
- Misses 11 533 +522
- Partials 30 201 +171
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this package is only used during testing, as its name suggests, it shouldn’t be in the
common
directory. I think it would be better to create atests
directory and move it there just like thedemos
directory.
@JianKangEgon Please move directory according to my comment.
common/autoware_test_utils/include/autoware_test_utils/visualization.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: JianKangEgon <egon.kang@autocore.ai>
Signed-off-by: JianKangEgon <egon.kang@autocore.ai>
Signed-off-by: NorahXiong <norah.xiong@autocore.ai>
Signed-off-by: NorahXiong <norah.xiong@autocore.ai>
2e54b04
to
6a38f3c
Compare
Fatih san @xmfcx and mits san @mitsudome-r I notice that you have create a test folder , for this "autoware_test_utils" Should I put "autoware_test_utils" under core/testing/ , alongside package autoware_testing that you created? Best regards 心刚 |
@liuXinGangChina Hello 👋
Yes, please 👍 |
got it, Fatih san have a nice weekend 心刚 |
Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
@liuXinGangChina I have moved the package to testing in this commit: a3074ea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
autoware_pyplot
was finally ported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied my suggestions 2024e7f by myself. LGTM
Waiting for: autowarefoundation/autoware.universe#10175 |
This must be merged with: autowarefoundation/autoware.universe#10177 |
Description
We are porting autoware_test_utils to autoware.core, and this PR adds the package to core.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.