-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port autoware_route_handler from Autoware Universe #201
base: main
Are you sure you want to change the base?
feat: port autoware_route_handler from Autoware Universe #201
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a porting PR so that I only conducted a minimal review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Here is the failed cppcheck report:
I will try to fix them or add exceptions. |
Will create a PR to add For the porting process, let's keep the changes to minimum. And then gradually remove the restrictions once basic move operations are finished. Created the PR: |
Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
a45151b
to
0b42f5e
Compare
@mitsudome-r -san, shouldn't there be a PR on universe side that removes this package? Couldn't find here: https://github.com/search?q=repo%3Aautowarefoundation%2Fautoware.universe+autoware_route_handler&type=pullrequests Here is the package: https://github.com/autowarefoundation/autoware.universe/tree/769673c95d12a6361c6e3e89c5bd10ab5e1cadba/planning/autoware_route_handler |
Also the CI doesn't pass: https://github.com/autowarefoundation/autoware.core/actions/runs/13537260433/job/37831081771?pr=201#step:5:6907
|
Co-authored-by: Mete Fatih Cırıt <xmfcx@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
===========================================
- Coverage 78.75% 22.32% -56.44%
===========================================
Files 11 23 +12
Lines 193 2101 +1908
Branches 73 735 +662
===========================================
+ Hits 152 469 +317
- Misses 11 1473 +1462
- Partials 30 159 +129
☔ View full report in Codecov by Sentry. |
Description
This PR ports autoware_route_handler from Autoware Universe as part of #190
Related links
Parent Issue:
This PR must be merged after:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.