Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_object_recognition_utils): move to core #232

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

liuXinGangChina
Copy link
Contributor

@liuXinGangChina liuXinGangChina commented Mar 3, 2025

Description

porting autoware_object_recognition_utils to core repo

Related links

Parent Issue:

How was this PR tested?

  1. colcon build with all autoware packages
  2. finish A-2-B task in planning simulator, with dummy cars and pedestrians

Notes for reviewers

Interface changes

None.

Effects on system behavior

None.

@liuXinGangChina liuXinGangChina added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:moving Temporary label to represent packages that are specifically moving from Universe to Core. labels Mar 3, 2025
@liuXinGangChina liuXinGangChina self-assigned this Mar 3, 2025
Copy link

github-actions bot commented Mar 3, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 63.50975% with 262 lines in your changes missing coverage. Please review.

Project coverage is 37.34%. Comparing base (4cb18f5) to head (c094cba).
Report is 63 commits behind head on main.

Files with missing lines Patch % Lines
...ition_utils/test/src/test_predicted_path_utils.cpp 36.95% 0 Missing and 87 partials ⚠️
...ect_recognition_utils/test/src/test_conversion.cpp 44.35% 0 Missing and 69 partials ⚠️
...tion_utils/test/src/test_object_classification.cpp 58.06% 0 Missing and 39 partials ⚠️
...bject_recognition_utils/test/src/test_geometry.cpp 50.00% 0 Missing and 28 partials ⚠️
...bject_recognition_utils/test/src/test_matching.cpp 87.32% 0 Missing and 18 partials ⚠️
...ude/autoware/object_recognition_utils/matching.hpp 84.31% 0 Missing and 8 partials ⚠️
...toware_object_recognition_utils/src/conversion.cpp 74.07% 7 Missing ⚠️
...ect_recognition_utils/src/predicted_path_utils.cpp 92.30% 1 Missing and 3 partials ⚠️
...object_recognition_utils/object_classification.hpp 94.28% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #232       +/-   ##
===========================================
- Coverage   78.75%   37.34%   -41.42%     
===========================================
  Files          11       24       +13     
  Lines         193     1462     +1269     
  Branches       73      527      +454     
===========================================
+ Hits          152      546      +394     
- Misses         11      647      +636     
- Partials       30      269      +239     
Flag Coverage Δ
differential 37.34% <63.50%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

liuXinGangChina and others added 2 commits March 5, 2025 15:20
…t_recognition_utils, initial commit: v0.0

Signed-off-by: liuXinGangChina <lxg19892021@gmail.com>
@liuXinGangChina liuXinGangChina force-pushed the autoware-object-recognition-utils-migration branch from 5c864db to c094cba Compare March 5, 2025 07:20
@mitsudome-r mitsudome-r merged commit 73351c0 into main Mar 5, 2025
23 of 26 checks passed
@mitsudome-r mitsudome-r deleted the autoware-object-recognition-utils-migration branch March 5, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:moving Temporary label to represent packages that are specifically moving from Universe to Core.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants