Skip to content

Commit

Permalink
final
Browse files Browse the repository at this point in the history
  • Loading branch information
PanConChicharron committed Mar 6, 2025
1 parent 18e9a2b commit 54776f0
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
terminal_stop_margin : 3.0 # Stop margin at the goal. This value cannot exceed stop margin. [m]
min_behavior_stop_margin: 3.0 # [m]

stop_margin_opposing_traffic: 5.0
additional_stop_margin_opposing_traffic: 5.0

hold_stop_velocity_threshold: 0.01 # The maximum ego velocity to hold stopping [m/s]
hold_stop_distance_threshold: 0.3 # The ego keeps stopping if the distance to stop changes within the threshold [m]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,7 @@ double ObstacleStopModule::calc_desired_stop_margin(
return stop_planning_param_.terminal_stop_margin;
}
return stop_planning_param_.stop_margin;
}() + (stop_obstacle.velocity < 0.0) ? stop_planning_param_.stop_margin_opposing_traffic : 0.0;
}() + (stop_obstacle.velocity < 0.0) ? stop_planning_param_.additional_stop_margin_opposing_traffic : 0.0;

Check failure on line 901 in planning/motion_velocity_planner/autoware_motion_velocity_obstacle_stop_module/src/obstacle_stop_module.cpp

View workflow job for this annotation

GitHub Actions / cppcheck-differential

Clarify calculation precedence for '+' and '?'. [clarifyCalculation]

// calculate stop margin on curve
const double stop_margin_on_curve = calc_margin_from_obstacle_on_curve(
Expand All @@ -915,10 +915,10 @@ double ObstacleStopModule::calc_desired_stop_margin(
const double stop_dist_diff =
closest_behavior_stop_dist_on_ref_traj - (dist_to_collide_on_ref_traj - stop_margin_on_curve);
if (0.0 < stop_dist_diff && stop_dist_diff < stop_margin_on_curve) {
return stop_planning_param_.min_behavior_stop_margin + (stop_obstacle.velocity < 0.0) ? stop_planning_param_.stop_margin_opposing_traffic;
return stop_planning_param_.min_behavior_stop_margin + (stop_obstacle.velocity < 0.0) ? stop_planning_param_.additional_stop_margin_opposing_traffic : 0.0;

Check failure on line 918 in planning/motion_velocity_planner/autoware_motion_velocity_obstacle_stop_module/src/obstacle_stop_module.cpp

View workflow job for this annotation

GitHub Actions / cppcheck-differential

Clarify calculation precedence for '+' and '?'. [clarifyCalculation]
}
}
return stop_margin_on_curve + (stop_obstacle.velocity < 0.0) ? stop_planning_param_.stop_margin_opposing_traffic;
return stop_margin_on_curve + (stop_obstacle.velocity < 0.0) ? stop_planning_param_.additional_stop_margin_opposing_traffic : 0.0;

Check failure on line 921 in planning/motion_velocity_planner/autoware_motion_velocity_obstacle_stop_module/src/obstacle_stop_module.cpp

View workflow job for this annotation

GitHub Actions / cppcheck-differential

Clarify calculation precedence for '+' and '?'. [clarifyCalculation]
}

std::optional<double> ObstacleStopModule::calc_candidate_zero_vel_dist(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ struct StopPlanningParam
double stop_margin{};
double terminal_stop_margin{};
double min_behavior_stop_margin{};
double stop_margin_opposing_traffic{};
double additional_stop_margin_opposing_traffic{};
double hold_stop_velocity_threshold{};
double hold_stop_distance_threshold{};
bool enable_approaching_on_curve{};
Expand Down Expand Up @@ -186,8 +186,8 @@ struct StopPlanningParam
get_or_declare_parameter<double>(node, "obstacle_stop.stop_planning.terminal_stop_margin");
min_behavior_stop_margin = get_or_declare_parameter<double>(
node, "obstacle_stop.stop_planning.min_behavior_stop_margin");
stop_margin_opposing_traffic =
get_or_declare_parameter<double>(node, "obstacle_stop.stop_planning.stop_margin_opposing_traffic");
additional_stop_margin_opposing_traffic =
get_or_declare_parameter<double>(node, "obstacle_stop.stop_planning.additional_stop_margin_opposing_traffic");
hold_stop_velocity_threshold = get_or_declare_parameter<double>(
node, "obstacle_stop.stop_planning.hold_stop_velocity_threshold");
hold_stop_distance_threshold = get_or_declare_parameter<double>(
Expand Down

0 comments on commit 54776f0

Please sign in to comment.