Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoware_auto_control_msgs): replace autoware_auto_control_msgs with autoware_control_msgs #3674

Closed
5 tasks done
xmfcx opened this issue May 11, 2023 · 5 comments
Closed
5 tasks done
Assignees
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned)

Comments

@xmfcx
Copy link
Contributor

xmfcx commented May 11, 2023

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

Replace all usages of

mfc@mfc-leo:~/projects/autoware/src$ grep -ril "autoware_auto_control_msgs::" ./
./vehicle/external/pacmod_interface/pacmod_interface/README.md
./vehicle/external/pacmod_interface/pacmod_interface/include/pacmod_interface/pacmod_interface.hpp
./vehicle/external/pacmod_interface/pacmod_interface/include/pacmod_interface/pacmod_diag_publisher.hpp
./vehicle/external/pacmod_interface/pacmod_interface/src/pacmod_interface/pacmod_interface.cpp
./universe/autoware.universe/common/tier4_control_rviz_plugin/README.md
./universe/autoware.universe/common/tier4_control_rviz_plugin/src/tools/manual_controller.hpp
./universe/autoware.universe/vehicle/external_cmd_converter/README.md
./universe/autoware.universe/vehicle/external_cmd_converter/include/external_cmd_converter/node.hpp
./universe/autoware.universe/vehicle/external_cmd_converter/src/node.cpp
./universe/autoware.universe/vehicle/raw_vehicle_cmd_converter/README.md
./universe/autoware.universe/vehicle/raw_vehicle_cmd_converter/include/raw_vehicle_cmd_converter/node.hpp
./universe/autoware.universe/control/control_performance_analysis/README.md
./universe/autoware.universe/control/control_performance_analysis/include/control_performance_analysis/control_performance_analysis_node.hpp
./universe/autoware.universe/control/control_performance_analysis/include/control_performance_analysis/control_performance_analysis_core.hpp
./universe/autoware.universe/control/control_performance_analysis/src/control_performance_analysis_node.cpp
./universe/autoware.universe/control/trajectory_follower_base/include/trajectory_follower_base/lateral_controller_base.hpp
./universe/autoware.universe/control/trajectory_follower_base/include/trajectory_follower_base/longitudinal_controller_base.hpp
./universe/autoware.universe/control/pid_longitudinal_controller/include/pid_longitudinal_controller/pid_longitudinal_controller.hpp
./universe/autoware.universe/control/pid_longitudinal_controller/src/pid_longitudinal_controller.cpp
./universe/autoware.universe/control/mpc_lateral_controller/test/test_mpc.cpp
./universe/autoware.universe/control/mpc_lateral_controller/include/mpc_lateral_controller/mpc_lateral_controller.hpp
./universe/autoware.universe/control/mpc_lateral_controller/include/mpc_lateral_controller/mpc.hpp
./universe/autoware.universe/control/mpc_lateral_controller/src/mpc_lateral_controller.cpp
./universe/autoware.universe/control/vehicle_cmd_gate/README.md
./universe/autoware.universe/control/vehicle_cmd_gate/test/src/test_vehicle_cmd_filter.cpp
./universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_filter.hpp
./universe/autoware.universe/control/vehicle_cmd_gate/src/pause_interface.hpp
./universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.hpp
./universe/autoware.universe/control/shift_decider/README.md
./universe/autoware.universe/control/shift_decider/include/shift_decider/shift_decider.hpp
./universe/autoware.universe/control/shift_decider/src/shift_decider.cpp
./universe/autoware.universe/control/pure_pursuit/include/pure_pursuit/pure_pursuit_node.hpp
./universe/autoware.universe/control/pure_pursuit/include/pure_pursuit/pure_pursuit_lateral_controller.hpp
./universe/autoware.universe/control/pure_pursuit/src/pure_pursuit/pure_pursuit_node.cpp
./universe/autoware.universe/control/joy_controller/README.md
./universe/autoware.universe/control/joy_controller/include/joy_controller/joy_controller.hpp
./universe/autoware.universe/control/joy_controller/src/joy_controller/joy_controller_node.cpp
./universe/autoware.universe/control/trajectory_follower_node/test/test_longitudinal_controller_node.cpp
./universe/autoware.universe/control/trajectory_follower_node/test/test_lateral_controller_node.cpp
./universe/autoware.universe/control/trajectory_follower_node/test/test_controller_node.cpp
./universe/autoware.universe/control/trajectory_follower_node/design/simple_trajectory_follower-design.md
./universe/autoware.universe/control/trajectory_follower_node/include/trajectory_follower_node/controller_node.hpp
./universe/autoware.universe/control/trajectory_follower_node/include/trajectory_follower_node/simple_trajectory_follower.hpp
./universe/autoware.universe/control/trajectory_follower_node/src/controller_node.cpp
./universe/autoware.universe/control/operation_mode_transition_manager/src/state.hpp
./universe/autoware.universe/simulator/simple_planning_simulator/test/test_simple_planning_simulator.cpp
./universe/autoware.universe/simulator/simple_planning_simulator/include/simple_planning_simulator/simple_planning_simulator_core.hpp
./universe/autoware.universe/system/mrm_emergency_stop_operator/READEME.md
./universe/autoware.universe/system/mrm_emergency_stop_operator/include/mrm_emergency_stop_operator/mrm_emergency_stop_operator_core.hpp
./universe/autoware.universe/system/emergency_handler/README.md
./universe/autoware.universe/system/emergency_handler/include/emergency_handler/emergency_handler_core.hpp
./universe/autoware.universe/system/emergency_handler/src/emergency_handler/emergency_handler_core.cpp
./universe/external/tier4_ad_api_adaptor/awapi_awiv_adapter/include/awapi_awiv_adapter/awapi_awiv_adapter_core.hpp
./universe/external/tier4_ad_api_adaptor/awapi_awiv_adapter/include/awapi_awiv_adapter/awapi_vehicle_state_publisher.hpp
./universe/external/tier4_ad_api_adaptor/awapi_awiv_adapter/include/awapi_awiv_adapter/awapi_autoware_util.hpp
./universe/external/tier4_ad_api_adaptor/awapi_awiv_adapter/src/awapi_vehicle_state_publisher.cpp
./universe/external/tier4_ad_api_adaptor/awapi_awiv_adapter/src/awapi_awiv_adapter_core.cpp
./universe/external/tier4_ad_api_adaptor/autoware_iv_external_api_adaptor/src/vehicle_status.cpp
./universe/external/tier4_ad_api_adaptor/autoware_iv_external_api_adaptor/src/vehicle_status.hpp
./core/external/autoware_auto_msgs/autoware_auto_control_msgs/msg/AckermannControlCommand.idl

Purpose

To deprecate the autoware_auto_control_msgs and switch to autoware_control_msgs.

Possible approaches

We will probably have to modify all of these files in a single PR because they will depend on each other.

Definition of done

  • All the files in the description above are refactored.
  • autoware_auto_control_msgs is removed from the repository.

cc. @TakaHoribe @mehmetdogru @maxime-clem @beyzanurkaya @brkay54

@xmfcx xmfcx added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels May 11, 2023
@xmfcx xmfcx self-assigned this May 11, 2023
@xmfcx xmfcx moved this to Todo in Autoware Labs May 11, 2023
@xmfcx
Copy link
Contributor Author

xmfcx commented May 11, 2023

I will start working on this task.

@xmfcx
Copy link
Contributor Author

xmfcx commented May 22, 2023

This issue is blocked by:

@stale
Copy link

stale bot commented Sep 6, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Sep 6, 2023
@xmfcx xmfcx removed this from Autoware Labs Mar 18, 2024
@xmfcx
Copy link
Contributor Author

xmfcx commented Nov 7, 2024

We've completely migrated to autoware_msgs.

@xmfcx xmfcx closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
1 participant