Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_lidar_bevfusion): implementation of bevusion using tensorrt #10024

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

knzo25
Copy link
Contributor

@knzo25 knzo25 commented Jan 27, 2025

Description

This PR introduces BEVFusion to autoware using TensorRT.
However, it requires TensorRT10, which is being updated here
As such, this PR will remain as a draft until the previous PR gets merged.

In addition, the following dependencies are needed:

  • cuda-nvrtc-dev-12-4
  • spconv

A PR will be send to add nvrtc to autoware.
For spconv, two alternatives were talked with the AWF:

The onnx files will be provided after during the review of this PR of at the point of merging
I would like to ask reviewers to let the "integration" into the pipeline/launchers to a posterior PR 🙏

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…ion_ros2

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25 knzo25 requested a review from scepter914 January 27, 2025 05:14
@knzo25 knzo25 self-assigned this Jan 27, 2025
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) labels Jan 27, 2025
Copy link

github-actions bot commented Jan 27, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx
Copy link
Contributor

xmfcx commented Jan 27, 2025

@knzo25
Copy link
Contributor Author

knzo25 commented Jan 27, 2025

@xmfcx
Although both use viewtransform, they are different papers and modalities
https://arxiv.org/pdf/2112.11790
https://arxiv.org/pdf/2205.13542

@knzo25
Copy link
Contributor Author

knzo25 commented Feb 21, 2025

As TensorRT was upgraded and spconv was added (autowarefoundation/autoware#5794), I will be opening this PR 🎉

@knzo25 knzo25 marked this pull request as ready for review February 21, 2025 05:01
@knzo25 knzo25 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 21, 2025
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25 knzo25 requested a review from kminoda as a code owner February 25, 2025 01:26
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25 knzo25 removed the request for review from kminoda February 25, 2025 01:28
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Feb 25, 2025
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.79%. Comparing base (3677bda) to head (1b12f00).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10024      +/-   ##
==========================================
+ Coverage   26.41%   26.79%   +0.37%     
==========================================
  Files        1387     1394       +7     
  Lines      107397   107901     +504     
  Branches    41257    41522     +265     
==========================================
+ Hits        28373    28909     +536     
+ Misses      76186    76121      -65     
- Partials     2838     2871      +33     
Flag Coverage Δ *Carryforward flag
differential 3.48% <ø> (?)
differential-cuda 2.36% <ø> (?)
total 26.79% <ø> (+0.37%) ⬆️ Carriedforward from 1fb3ad2

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

2 participants