Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(planning): add missing exec_depend #10134

Conversation

isamu-takagi
Copy link
Contributor

Description

Add exec_depend to the package specified by find-pkg-share.

Related links

None

How was this PR tested?

Check if rosdep install succeeds.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi self-assigned this Feb 17, 2025
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 17, 2025
Copy link

github-actions bot commented Feb 17, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, pacakge name was wrong.. thanks

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.75%. Comparing base (b6afbf8) to head (be70998).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10134      +/-   ##
==========================================
- Coverage   26.75%   26.75%   -0.01%     
==========================================
  Files        1416     1418       +2     
  Lines      108454   108472      +18     
  Branches    41706    41706              
==========================================
+ Hits        29016    29017       +1     
- Misses      76566    76584      +18     
+ Partials     2872     2871       -1     
Flag Coverage Δ *Carryforward flag
differential 20.99% <ø> (?)
total 26.75% <ø> (ø) Carriedforward from b6afbf8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isamu-takagi isamu-takagi enabled auto-merge (squash) February 19, 2025 07:59
@isamu-takagi
Copy link
Contributor Author

@TakaHoribe @satoshi-ota @shmpwk @taikitanaka3 @tkimura4 Could someone from the code owners approve this?

@isamu-takagi isamu-takagi merged commit 3e7dd28 into autowarefoundation:main Mar 7, 2025
25 of 26 checks passed
@isamu-takagi isamu-takagi deleted the fix/exec-depend-planning-launch branch March 7, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants