fix(common): fix package name of find-pkg-share #10135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
isamu-takagi
requested review from
kyoichi-sugahara,
soblin,
TakaHoribe,
yhisaki,
zulfaqar-azmi-t4 and
taikitanaka3
as code owners
github-actions
bot
added
the
component:common
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
isamu-takagi
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10135 +/- ##
==========================================
- Coverage 26.25% 26.25% -0.01%
==========================================
Files 1381 1381
Lines 107503 107502 -1
Branches 41411 41410 -1
==========================================
- Hits 28229 28228 -1
- Misses 76459 76460 +1
+ Partials 2815 2814 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@isamu-takagi it should be fix launch pkg name etc.. |
isamu-takagi
changed the title
|
@taikitanaka3 Thank you. I fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add exec_depend to the package specified by find-pkg-share.The problem was with find-pkg-share, not exec_depend, so I fixed that.
Related links
None
How was this PR tested?
Check if rosdep install succeeds.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.