Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(motion_velocity_planner_universe): fix build depends (#10122) #10139

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Feb 17, 2025

Description

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@xmfcx xmfcx requested a review from mitsudome-r February 17, 2025 07:43
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 17, 2025
Copy link

github-actions bot commented Feb 17, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx xmfcx self-assigned this Feb 17, 2025
@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 17, 2025
@xmfcx
Copy link
Contributor Author

xmfcx commented Feb 17, 2025

We should have 2 versions of https://github.com/autowarefoundation/autoware.universe/blob/main/build_depends.repos for:

  • nightly
  • stable

PRs against humble branch should use the stable version.
PRs against the main branch should use the nightly version.

I'll look into how to parameterize this from the build-and-test-differential workflow based on the branch the PR is against.

@xmfcx
Copy link
Contributor Author

xmfcx commented Feb 17, 2025

quick prompting:

      - name: Set build-depends-repos
        run: |
          if [[ "${{ github.base_ref }}" == "main" ]]; then
            echo "BUILD_DEPENDS_REPOS=build_depends.repos" >> $GITHUB_ENV
          elif [[ "${{ github.base_ref }}" == "humble" ]]; then
            echo "BUILD_DEPENDS_REPOS=build_depends_humble.repos" >> $GITHUB_ENV
          else
            echo "BUILD_DEPENDS_REPOS=build_depends.repos" >> $GITHUB_ENV  # Default fallback
          fi

      - name: Build
        if: ${{ steps.get-modified-packages.outputs.modified-packages != '' }}
        uses: autowarefoundation/autoware-github-actions/colcon-build@v1
        with:
          rosdistro: ${{ inputs.rosdistro }}
          target-packages: ${{ steps.get-modified-packages.outputs.modified-packages }}
          build-depends-repos: ${{ env.BUILD_DEPENDS_REPOS }}
          cache-key-element: ${{ env.BUILD_TYPE_CUDA_STATE }}

something like this should do it. will implement it tomorrow.

Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also fixes the buildfarm build. Thanks @xmfcx !

xmfcx and others added 2 commits February 18, 2025 18:14
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@xmfcx xmfcx force-pushed the fix/grid-map-core branch from fbd6f27 to b25b10c Compare February 18, 2025 09:15
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Feb 18, 2025
@xmfcx
Copy link
Contributor Author

xmfcx commented Feb 18, 2025

I've made this PR include the commit from:

This PR will be merged with a merge commit to the humble branch.

Then another PR will be made to increment the version for patch.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.28%. Comparing base (b044958) to head (b25b10c).
Report is 4 commits behind head on humble.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble   #10139      +/-   ##
==========================================
- Coverage   29.28%   29.28%   -0.01%     
==========================================
  Files        1440     1442       +2     
  Lines      108118   108148      +30     
  Branches    42641    42641              
==========================================
+ Hits        31667    31671       +4     
+ Misses      73400    73349      -51     
- Partials     3051     3128      +77     
Flag Coverage Δ *Carryforward flag
differential 15.54% <ø> (-15.20%) ⬇️
differential-cuda 29.28% <ø> (ø) Carriedforward from b044958
total 29.21% <ø> (ø) Carriedforward from b044958

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xmfcx xmfcx merged commit 3cc0248 into humble Feb 18, 2025
35 checks passed
@xmfcx xmfcx deleted the fix/grid-map-core branch February 18, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants