-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(build-depends.repos): separate repos for humble and nightly #10148
Conversation
90de398
to
e8e5b21
Compare
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
e8e5b21
to
2e895aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can merge it once we confirm that https://github.com/autowarefoundation/autoware.universe/actions/runs/13384761188/job/37379350785 passes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10148 +/- ##
==========================================
- Coverage 26.76% 26.76% -0.01%
==========================================
Files 1416 1416
Lines 108463 108463
Branches 41715 41715
==========================================
- Hits 29033 29031 -2
- Misses 76554 76556 +2
Partials 2876 2876
☔ View full report in Codecov by Sentry. |
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
Description
Related Issue:
Humble counterpart:
build_depends.repos
file is used for pulling the dependencies of this repository while building it, currently used by CI.With the introduction of
autoware-nightly.repos
and pinning of the versions inautoware.repos
, the management of this file became a bit complicated.This repository has 2 branches:
main
andhumble
. This PR introduces the following configuration for both these:PRs against
main
branch & CI that operates onmain
They should utilize
build_depends_humble.repos
that is overridden bybuild_depends_nightly.repos
.To simplify this, I've added a new action that will overlay one
.repos
file onto another.Using this new
combine-repos-action
these CI workflows now use the overlaid.repos
file.The reason for not having 2
.build_depends.repos
files with some duplicate information and going with override option is to simplify version maintenance.PRs against
humble
branchThese utilize
build_depends_humble.repos
as it is. The condition for this case is only triggered by*-differential
workflows.How was this PR tested?