-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lane_departure_checker): fix trajectory resampling logic to keep given interval #10221
fix(lane_departure_checker): fix trajectory resampling logic to keep given interval #10221
Conversation
…given interval Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…tances followed by large distance Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10221 +/- ##
=======================================
Coverage 26.40% 26.40%
=======================================
Files 1390 1390
Lines 107718 107719 +1
Branches 41501 41496 -5
=======================================
+ Hits 28442 28445 +3
+ Misses 76440 76439 -1
+ Partials 2836 2835 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! checked with with rosbag that was collected on 2025-02-07.
6ef2396
into
autowarefoundation:main
…given interval (autowarefoundation#10221) * fix(lane_departure_checker): fix trajectory resampling logic to keep given interval Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * test(lane_departure_checker): add test case for consecutive small distances followed by large distance Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Description
Fixed a bug in the resampleTrajectory function where the
prev_point
was being updated even when a trajectory point was not added to the resampled trajectory. This caused incorrect distance calculations and potentially led to trajectory points being improperly filtered.Related links
Private Links:
How was this PR tested?
green point: resampled points
behavior before the change:
2025-03-04_11.33.10.mp4
behvior after the change:
2025-03-04_11.34.51.mp4
original code fails as follows
updated code succeed as follows
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.