Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compare_map_filter): deadlock bug fix #10222

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+152 −117

fix: change to lock_guard

52c5459
Select commit
Loading
Failed to load commit list.
Open

fix(compare_map_filter): deadlock bug fix #10222

fix: change to lock_guard
52c5459
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Mar 5, 2025 in 39s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Excess Number of Function Arguments)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
voxel_grid_map_loader.cpp 1 advisory rule 7.74 → 7.51 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Excess Number of Function Arguments voxel_grid_map_loader.cpp: VoxelGridDynamicMapLoader::is_close_to_next_map_grid

Annotations

Check warning on line 339 in perception/autoware_compare_map_segmentation/src/voxel_grid_map_loader/voxel_grid_map_loader.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments 

VoxelGridDynamicMapLoader::is_close_to_next_map_grid has 8 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
View more details on CodeScene Delta Analysis