fix(compare_map_filter): deadlock bug fix #10222
+152
−117
Open
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Mar 7, 2025 in 28s
CodeScene PR Check
Quality Gate Failed
Gates Failed
(1 file with Primitive Obsession, Excess Number of Function Arguments)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| voxel_grid_map_loader.cpp | 2 advisory rules | 7.74 → 7.28 | Suppress |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Primitive Obsession voxel_grid_map_loader.cpp
- Excess Number of Function Arguments voxel_grid_map_loader.cpp: VoxelGridDynamicMapLoader::is_close_to_next_map_grid
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Primitive Obsession
In this module, 42.3% of all function arguments are primitive types, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Excess Number of Function Arguments
VoxelGridDynamicMapLoader::is_close_to_next_map_grid has 8 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Loading