Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_pointcloud_preprocessor): add roi excluded downsample #10233

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kaancolak
Copy link
Contributor

Description

This filter provides selective downsampling that preserves detailed point data in critical regions while reducing overall point cloud density:

  1. Points are classified based on their position relative to a defined Region of Interest (ROI)
  2. Points inside the ROI are preserved at their original density (no downsampling)
  3. Points outside the ROI undergo standard voxel grid downsampling
  4. The final output combines both sets of points

The main purpose is to detect long-range stationary vehicles on the road, such as those stopped at an intersection or traffic light. With the point cloud densifier node, points at a distance will be densified and downsampling will not be applied in this densified area thanks to the roi excluded voxel-based downsampling operation.

2025-03-05.15-12-08.mp4

Parent Issue:

Private Links:

How was this PR tested?

Notes for reviewers

run -> ros2 launch autoware_pointcloud_preprocessor roi_excluded_voxel_grid_downsample_filter.launch.xml

Interface changes

None.

Effects on system behavior

None.

@kaancolak kaancolak added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Mar 5, 2025
@kaancolak kaancolak self-assigned this Mar 5, 2025
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) and removed component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Mar 5, 2025
Copy link

github-actions bot commented Mar 5, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kaancolak kaancolak force-pushed the feat/add-roi-excluded-voxel-grid branch from 46b11ac to 1982bc7 Compare March 5, 2025 15:03
@kaancolak kaancolak changed the title Add roi_excluded_voxel_grid_downsample_filter_node feat(autoware_pointcloud_preprocessor): add roi excluded downsample Mar 5, 2025
Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
@kaancolak kaancolak force-pushed the feat/add-roi-excluded-voxel-grid branch from be3b755 to 0c63f77 Compare March 5, 2025 18:55
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 1.19048% with 166 lines in your changes missing coverage. Please review.

Project coverage is 26.35%. Comparing base (4649cf6) to head (5938dd6).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...i_excluded_faster_voxel_grid_downsample_filter.cpp 0.00% 113 Missing ⚠️
...roi_excluded_voxel_grid_downsample_filter_node.cpp 2.17% 45 Missing ⚠️
...i_excluded_faster_voxel_grid_downsample_filter.hpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10233      +/-   ##
==========================================
- Coverage   26.40%   26.35%   -0.05%     
==========================================
  Files        1390     1393       +3     
  Lines      107719   107904     +185     
  Branches    41501    41578      +77     
==========================================
+ Hits        28442    28443       +1     
- Misses      76442    76626     +184     
  Partials     2835     2835              
Flag Coverage Δ *Carryforward flag
differential 23.55% <1.19%> (?)
differential-cuda 21.37% <1.19%> (?)
total 26.40% <ø> (-0.01%) ⬇️ Carriedforward from b4559fd

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

1 participant