Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_pointcloud_preprocessor): add roi excluded downsample #10233

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

style(pre-commit): autofix

5938dd6
Select commit
Loading
Failed to load commit list.
Open

feat(autoware_pointcloud_preprocessor): add roi excluded downsample #10233

style(pre-commit): autofix
5938dd6
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Mar 5, 2025 in 42s

CodeScene PR Check

Quality Gate Failed

Gates Failed
New code is healthy (1 new file with code health below 9.00)
Enforce critical code health rules (1 file with Bumpy Road Ahead)
Enforce advisory code health rules (1 file with Complex Method, Complex Conditional)

Gates Passed
1 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
New code is healthy Violations Code Health Impact
roi_excluded_faster_voxel_grid_downsample_filter.cpp 3 rules 10.00 → 8.48 Suppress
Enforce critical code health rules Violations Code Health Impact
roi_excluded_faster_voxel_grid_downsample_filter.cpp 1 critical rule 10.00 → 8.48 Suppress
Enforce advisory code health rules Violations Code Health Impact
roi_excluded_faster_voxel_grid_downsample_filter.cpp 2 advisory rules 10.00 → 8.48 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Conditional roi_excluded_faster_voxel_grid_downsample_filter.cpp: RoiExcludedFasterVoxelGridDownsampleFilter::filter
  • Complex Method roi_excluded_faster_voxel_grid_downsample_filter.cpp: RoiExcludedFasterVoxelGridDownsampleFilter::filter
  • Complex Conditional roi_excluded_faster_voxel_grid_downsample_filter.cpp: RoiExcludedFasterVoxelGridDownsampleFilter::get_min_max_voxel
  • Complex Conditional roi_excluded_faster_voxel_grid_downsample_filter.cpp: RoiExcludedFasterVoxelGridDownsampleFilter::calc_centroids_each_voxel
  • Bumpy Road Ahead roi_excluded_faster_voxel_grid_downsample_filter.cpp: RoiExcludedFasterVoxelGridDownsampleFilter::filter

Annotations

Check warning on line 239 in sensing/autoware_pointcloud_preprocessor/src/downsample_filter/roi_excluded_faster_voxel_grid_downsample_filter.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

RoiExcludedFasterVoxelGridDownsampleFilter::filter has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 90 in sensing/autoware_pointcloud_preprocessor/src/downsample_filter/roi_excluded_faster_voxel_grid_downsample_filter.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

RoiExcludedFasterVoxelGridDownsampleFilter::get_min_max_voxel has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 124 in sensing/autoware_pointcloud_preprocessor/src/downsample_filter/roi_excluded_faster_voxel_grid_downsample_filter.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

RoiExcludedFasterVoxelGridDownsampleFilter::calc_centroids_each_voxel has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 174 in sensing/autoware_pointcloud_preprocessor/src/downsample_filter/roi_excluded_faster_voxel_grid_downsample_filter.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

RoiExcludedFasterVoxelGridDownsampleFilter::filter has 1 complex conditionals with 3 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 239 in sensing/autoware_pointcloud_preprocessor/src/downsample_filter/roi_excluded_faster_voxel_grid_downsample_filter.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

RoiExcludedFasterVoxelGridDownsampleFilter::filter has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.