Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(control_validator): add diag to check control component latency #10240

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Mar 6, 2025

Description

⚠️ Please review and approve autowarefoundation/autoware_launch#1349 first.

I added a feature to calculate control component latency and to publish error diagnostic if it is larger than threshold.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

Add new field to publish current latency.

diff --git a/control/autoware_control_validator/msg/ControlValidatorStatus.msg b/control/autoware_control_validator/msg/ControlValidatorStatus.msg
index 5db179f5a9..c40f160510 100644
--- a/control/autoware_control_validator/msg/ControlValidatorStatus.msg
+++ b/control/autoware_control_validator/msg/ControlValidatorStatus.msg
@@ -4,10 +4,12 @@ builtin_interfaces/Time stamp
 bool is_valid_max_distance_deviation
 bool is_rolling_back
 bool is_over_velocity
+bool is_valid_latency
 
 # values
 float64 max_distance_deviation
 float64 target_vel
 float64 vehicle_vel
+float64 latency
 
 int64 invalid_count

Effects on system behavior

None.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@satoshi-ota satoshi-ota added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:clang-tidy-pr-review labels Mar 7, 2025
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 26.25%. Comparing base (92da629) to head (c1cdca2).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...toware_control_validator/src/control_validator.cpp 25.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10240      +/-   ##
==========================================
- Coverage   26.25%   26.25%   -0.01%     
==========================================
  Files        1381     1381              
  Lines      107503   107536      +33     
  Branches    41411    41418       +7     
==========================================
+ Hits        28229    28233       +4     
- Misses      76459    76488      +29     
  Partials     2815     2815              
Flag Coverage Δ *Carryforward flag
differential 7.76% <25.00%> (?)
total 26.25% <ø> (+<0.01%) ⬆️ Carriedforward from 92da629

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@satoshi-ota satoshi-ota merged commit 35d0ee7 into autowarefoundation:main Mar 7, 2025
33 of 34 checks passed
@satoshi-ota satoshi-ota deleted the feat/measure-control-latency branch March 7, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:clang-tidy-pr-review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants