Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static_obstacle_avoidance): ego doesn't keep stopping in unsafe condition #10242

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Mar 7, 2025

Description

Bug: The ego couldn't keep stopping in front of the avoidance target during yielding. This issue was caused by #9089.

The purpose of #9089 was removing stop line and preventing stuck when the ego obiously overrun the stop line. But it removed stop line even when it stopped properly since threre is no buffer.

movie-2025-03-07_09.13.21.mp4

Related links

Parent Issue:

How was this PR tested?

Ego keeps stopping during yielding.

movie-2025-03-07_09.09.45.mp4

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…ondition

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 7, 2025
Copy link

github-actions bot commented Mar 7, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@satoshi-ota satoshi-ota added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:clang-tidy-pr-review labels Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 26.23%. Comparing base (92da629) to head (d7933f3).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ath_static_obstacle_avoidance_module/src/scene.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10242      +/-   ##
==========================================
- Coverage   26.25%   26.23%   -0.03%     
==========================================
  Files        1381     1381              
  Lines      107503   107504       +1     
  Branches    41411    41407       -4     
==========================================
- Hits        28229    28202      -27     
- Misses      76459    76492      +33     
+ Partials     2815     2810       -5     
Flag Coverage Δ *Carryforward flag
differential 21.39% <0.00%> (?)
total 26.23% <ø> (-0.03%) ⬇️ Carriedforward from 92da629

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@satoshi-ota satoshi-ota merged commit 1fe0d21 into autowarefoundation:main Mar 7, 2025
62 of 64 checks passed
@satoshi-ota satoshi-ota deleted the fix/soa-stop-logic branch March 7, 2025 04:28
kotaro-hihara pushed a commit to tier4/autoware.universe that referenced this pull request Mar 7, 2025
…ondition (autowarefoundation#10242)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:clang-tidy-pr-review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants