-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_automatic_goal_rviz_plugin): make it possible to register checkpoints #6153
feat(tier4_automatic_goal_rviz_plugin): make it possible to register checkpoints #6153
Conversation
…checkpoints Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
36fb912
to
6c178c2
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6153 +/- ##
==========================================
- Coverage 14.58% 14.58% -0.01%
==========================================
Files 1868 1869 +1
Lines 127493 127557 +64
Branches 37317 37317
==========================================
Hits 18600 18600
- Misses 87974 88038 +64
Partials 20919 20919
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FYI @mehmetdogru @MertClk |
…checkpoints (autowarefoundation#6153) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
Make it possible to register checkpoints. (Previously, only goal point was supported.)
How to use
AutowareAutomaticGoalPanel
AutowareAutomaticGoalPanel
AutomaticGoalAppendTool
AutomaticCheckpointAppendTool
simplescreenrecorder-2024-01-24_16.36.17.mp4
Tests performed
Please select goal before adding checkpoints. Checkpoints is added to route to the goal.
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.