Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pose_initializer): fix README and json schema default value #6342

Conversation

KYabuuchi
Copy link
Contributor

@KYabuuchi KYabuuchi commented Feb 7, 2024

Description

  • Removed conventional parameter table in README.md.
  • Removed \n in array of JSON schema.

Tests performed

  • I have confirmed that JSON validation pass well.
cd autoware/src/universe/autoware.universe/localization
find -wholename '*/schema/*.schema.json' -printf '%p: ' -execdir bash -c 'check-jsonschema --schemafile "$1" ../config/"${1:2:-12}"*.param.yaml' bash '{}' +
  • Documentation is fixed

before

after

Effects on system behavior

Does not affect.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) labels Feb 7, 2024
@KYabuuchi KYabuuchi added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Feb 7, 2024
KYabuuchi and others added 2 commits February 21, 2024 10:27
…se_initializer

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
@KYabuuchi KYabuuchi changed the title refactor(pose_initializer): fix some items related to parameters fdocs(pose_initializer): fix README and json schema default value Feb 21, 2024
@KYabuuchi KYabuuchi changed the title fdocs(pose_initializer): fix README and json schema default value docs(pose_initializer): fix README and json schema default value Feb 21, 2024
@KYabuuchi KYabuuchi added run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) and removed run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) labels Feb 21, 2024
@KYabuuchi KYabuuchi marked this pull request as ready for review February 21, 2024 01:45
@KYabuuchi
Copy link
Contributor Author

The depoly-docs are falling because of this PR #6444
I will fix it by another PR.

@KYabuuchi
Copy link
Contributor Author

#6465 will fix the deploy-docs failling.

@YamatoAndo YamatoAndo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 21, 2024
@KYabuuchi KYabuuchi enabled auto-merge (squash) February 21, 2024 04:44
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9120c08) 15.10% compared to head (2b91196) 15.10%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6342   +/-   ##
=======================================
  Coverage   15.10%   15.10%           
=======================================
  Files        1823     1823           
  Lines      126292   126292           
  Branches    38188    38188           
=======================================
  Hits        19077    19077           
  Misses      85825    85825           
  Partials    21390    21390           
Flag Coverage Δ *Carryforward flag
differential 7.56% <ø> (?)
total 15.10% <ø> (ø) Carriedforward from 9120c08

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KYabuuchi KYabuuchi merged commit 8ccb957 into autowarefoundation:main Feb 21, 2024
44 of 48 checks passed
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…owarefoundation#6342)

* remove conventional parameter table

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* remove \n in array in json

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* add map_loader_name in param.yaml

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
* remove conventional parameter table

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* remove \n in array in json

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* add map_loader_name in param.yaml

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…owarefoundation#6342)

* remove conventional parameter table

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* remove \n in array in json

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* add map_loader_name in param.yaml

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants