Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ndt_scan_matcher): detect loss PCD #6735

Closed
wants to merge 31 commits into from

style(pre-commit): autofix

1a852f2
Select commit
Loading
Failed to load commit list.
Closed

feat(ndt_scan_matcher): detect loss PCD #6735

style(pre-commit): autofix
1a852f2
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Apr 5, 2024 in 1m 11s

CodeScene PR Check

✅ Code Health Quality Gates: OK

View detailed results in CodeScene

Details

Annotations

Check notice on line 175 in localization/ndt_scan_matcher/src/map_update_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Complex Method 

MapUpdateModule::update_ndt increases in cyclomatic complexity from 9 to 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis